Skip to content

Conversation

kanhaiya5590
Copy link

Description (*)

Task

https://pagespeed.web.dev/ - PageSpeed Insights

Performance improvement - after changes result => All text remains visible during Webfont loads

Before changes - Ensure text remains visible during Webfont load
image

After changes - All text remains visible during Webfont loads

image

 Fixed and result changes - All text remains visible during Webfont loads
@kanhaiya5590
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590
Copy link
Author

Static Tests failed in a different place in the code - anyone can help on this as changes have not impacted that.

@paras89
Copy link
Contributor

paras89 commented Jan 9, 2023

HI @kanhaiya5590, as part of the process, need to fix the static test failures in the file that was edited.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

We are picking this PR for further development

@engcom-Hotel
Copy link
Collaborator

@magento run Static Tests

@engcom-Hotel
Copy link
Collaborator

@magento run Static Tests

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Hotel
Copy link
Collaborator

The Failed tests seem flaky to me. Hence moving this PR in testing

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Bravo
Copy link
Collaborator

Hi @kanhaiya5590,

Thanks for the collaboration & contribution!.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshot.

Screenshot 2024-05-27 at 12 29 32

Could you please try to reproduce the issue in Latest 2.4-develop instance and could you please let us know if we are still missing anything.

Thanks.

@engcom-Bravo
Copy link
Collaborator

Hi @kanhaiya5590,

We are not able to reproduce the issue.

Can you please confirm the issue still exist on 2.4-develop?

please refer to this #834 (comment)

Lets us know if you are still facing the issue on 2.4-develop with detailed steps.

Moving it to on hold

Thanks.

@engcom-Bravo
Copy link
Collaborator

HI @kanhaiya5590,

Thank you for your contribution!

As mentioned #834 (comment), please have a look and let us know if we are missing anything.

Till then closing this PR. Please feel free to reopen it as you want to update further.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project: Community Picked PRs upvoted by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants