Fixed: Incorrect discount amount for whole cart #37730

aasim110 · 2023-07-06T18:57:15Z

Description (*)

Fixed: Incorrect discount amount when using fixed discount amount for the whole cart

Related Pull Requests

Fixed Issues (if relevant)

Fixes Cart price rules - Incorrect discount amount when using fixed discount amount for whole cart #37496

Manual testing scenarios (*)

Check this steps for Manual testing : #37496 (comment)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2023-07-06T18:57:18Z

Hi @aasim110. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

aasim110 · 2023-07-06T18:57:36Z

@magento run all tests

magento-automated-testing · 2023-07-06T18:57:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-07T04:52:37Z

@magento run WebAPI Tests, Static Tests

magento-automated-testing · 2023-07-07T04:52:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-07T06:44:15Z

@magento run all tests

magento-automated-testing · 2023-07-07T06:44:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-07T11:16:57Z

@magento run Database Compare

magento-automated-testing · 2023-07-07T11:17:03Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-07T12:57:06Z

@magento run Integration Tests

magento-automated-testing · 2023-07-07T12:57:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-10T05:05:12Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2023-07-10T05:05:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

… whole cart

aasim110 · 2023-07-10T06:50:20Z

@magento run all tests

magento-automated-testing · 2023-07-10T06:50:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-10T11:41:28Z

@magento run WebAPI Tests, Integration Tests

magento-automated-testing · 2023-07-10T11:41:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-11T13:05:27Z

@magento run Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2023-07-11T13:05:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

aasim110 · 2023-07-12T04:36:02Z

@magento run Functional Tests CE

magento-automated-testing · 2023-07-12T04:36:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Lima · 2023-07-27T13:24:43Z

@magento run all tests

magento-automated-testing · 2023-07-27T13:24:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel

Hello @aasim110,

Thanks for the reply here #37730 (comment)!

But actually, I think we need an automated test here to cover this particular scenario, in which the discount amount is displaying incorrectly.

aasim110 · 2023-08-08T11:34:41Z

@engcom-Hotel, I don't see any conceivable approach, as there's no requirement to include it for a specific scenario.

engcom-Hotel · 2023-08-10T06:36:53Z

Thanks @aasim110, for the reply! We are moving further with this PR.

engcom-Lima · 2023-08-14T13:09:13Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:
Create a Cart price rule:

1 - Marketing -> Promotions -> Cart Price Rules

Conditions: Subtotal (excl Tax)equals or greater than 1000

2 - Actions: Fixed amount discount for the whole cart
Discount amount 500

3 - Create a plugin afterGetPrice for the class Magento\Quote\Model\Quote\Item. method getPrice() or paste the Folder in the path app/code.
Magz.zip

4 - Choose a configurable product, and add it to the cart. The price will be changed to the new one, after that, apply the coupon code and Check the discount value.

Before: ✖️ Discount was showing 250 instead of 500

After: ✔️ Now showing 500

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Echo · 2023-08-16T04:49:33Z

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,Unit Tests,WebAPI Tests

magento-automated-testing · 2023-08-16T04:49:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-08-16T07:14:22Z

Failing test are not related to PR Hence moving it to Merge In Progress

engcom-Echo · 2023-08-18T02:44:08Z

@magento run all tests

magento-automated-testing · 2023-08-18T02:44:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-08-18T04:30:00Z

@magento run Functional Tests EE,Unit Tests ,WebAPI Tests

magento-automated-testing · 2023-08-18T04:30:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-08-18T04:57:06Z

@magento run Integration Tests,Functional Tests B2B

magento-automated-testing · 2023-08-18T04:57:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-08-18T06:21:02Z

@magento run Functional Tests EE

magento-automated-testing · 2023-08-18T06:21:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-08-18T08:36:57Z

Functional Tests B2B,Functional Tests EE Failures are different on last two run on same commit. Other build failures are not related to PR changes.
Functional Tests B2B
Run1

Run2

Functional Tests EE
Run1

Run2

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jul 6, 2023

Aasim Goriya added 2 commits July 10, 2023 12:19

Fixed: Incorrect discount amount when using fixed discount amount for…

6f74fd6

… whole cart

Fixed: Static Tests issue

8974d05

aasim110 force-pushed the cartrule-fix branch from 16224a3 to 8974d05 Compare July 10, 2023 06:49

sinhaparul added the Project: Community Picked PRs upvoted by the community label Jul 26, 2023

Merge branch '2.4-develop' into cartrule-fix

5c43ea6

engcom-Hotel requested changes Aug 8, 2023

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Aug 8, 2023

engcom-Hotel approved these changes Aug 10, 2023

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Aug 10, 2023

engcom-Lima self-assigned this Aug 11, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 11, 2023

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Aug 14, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Aug 16, 2023

Merge branch '2.4-develop' into cartrule-fix

0d6b22e

magento-devops-reposync-svc merged commit f906144 into magento:2.4-develop Aug 31, 2023

Fixed: Incorrect discount amount for whole cart #37730

Fixed: Incorrect discount amount for whole cart #37730

Uh oh!

Conversation

aasim110 commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 6, 2023

Uh oh!

aasim110 commented Jul 6, 2023

Uh oh!

magento-automated-testing bot commented Jul 6, 2023

Uh oh!

aasim110 commented Jul 7, 2023

Uh oh!

magento-automated-testing bot commented Jul 7, 2023

Uh oh!

aasim110 commented Jul 7, 2023

Uh oh!

magento-automated-testing bot commented Jul 7, 2023

Uh oh!

aasim110 commented Jul 7, 2023

Uh oh!

magento-automated-testing bot commented Jul 7, 2023

Uh oh!

aasim110 commented Jul 7, 2023

Uh oh!

magento-automated-testing bot commented Jul 7, 2023

Uh oh!

aasim110 commented Jul 10, 2023

Uh oh!

magento-automated-testing bot commented Jul 10, 2023

Uh oh!

aasim110 commented Jul 10, 2023

Uh oh!

magento-automated-testing bot commented Jul 10, 2023

Uh oh!

aasim110 commented Jul 10, 2023

Uh oh!

magento-automated-testing bot commented Jul 10, 2023

Uh oh!

aasim110 commented Jul 11, 2023

Uh oh!

magento-automated-testing bot commented Jul 11, 2023

Uh oh!

aasim110 commented Jul 12, 2023

Uh oh!

magento-automated-testing bot commented Jul 12, 2023

Uh oh!

engcom-Lima commented Jul 27, 2023

Uh oh!

magento-automated-testing bot commented Jul 27, 2023

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

aasim110 commented Aug 8, 2023

Uh oh!

engcom-Hotel commented Aug 10, 2023

Uh oh!

engcom-Lima commented Aug 14, 2023

✔️ QA Passed

Uh oh!

engcom-Echo commented Aug 16, 2023

Uh oh!

magento-automated-testing bot commented Aug 16, 2023

Uh oh!

engcom-Echo commented Aug 16, 2023

Uh oh!

engcom-Echo commented Aug 18, 2023

Uh oh!

magento-automated-testing bot commented Aug 18, 2023

Uh oh!

engcom-Echo commented Aug 18, 2023

aasim110 commented Jul 6, 2023 •

edited

Loading