fix: Use Object Manager for ModeConfigured #38886

pmzandbergen · 2024-06-27T12:21:06Z

Fixing #38875 (AC-12299)

Description (*)

Use Object Manager to create objects.

Related Pull Requests

N/A

Fixed Issues (if relevant)

Fixes Object Manager not used for Magento\Csp\Model\Mode\Data\ModeConfigured #38875 (AC-12299)

Manual testing scenarios (*)

N/A

Questions or comments

Created this PR @glo24157 , feel free to modify or include with your changes. Also see comments at 1b21cb8

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Fixing magento#38875 (AC-12299)

m2-assistant · 2024-06-27T12:21:09Z

Hi @pmzandbergen. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

pmzandbergen · 2024-06-27T12:28:39Z

@magento run all tests

Den4ik

Hi @pmzandbergen
Thanks for contribution. Please rolling back type casting for $reportOnly argument

app/code/Magento/Csp/Model/Mode/ConfigManager.php

Co-authored-by: Denis Kopylov <[email protected]>

Den4ik · 2024-07-08T12:09:39Z

@magento run all tests

Den4ik · 2024-07-08T17:54:14Z

@magento run Unit Tests

Den4ik · 2024-07-09T17:50:19Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

Den4ik · 2024-07-11T09:44:16Z

@magento run Unit Tests, Functional Tests CE

Den4ik · 2024-07-15T14:06:40Z

@magento run all tests

pmzandbergen · 2024-07-16T13:40:17Z

Please rolling back type casting for $reportOnly argument

@Den4ik do you want me to roll back the type casting (and why)? The failing tests don't seem to be relevant to this change.

Den4ik · 2024-07-16T20:18:53Z

Failed tests seems are not related and looks strange that they are failed. Let's try one more time and compare results of failed tests

Den4ik · 2024-07-16T20:19:12Z

@magento run all tests

Den4ik · 2024-07-18T13:35:50Z

@magento run Unit Tests

Den4ik

@pmzandbergen Could you please review my comment

app/code/Magento/Csp/Model/Mode/ConfigManager.php

engcom-Dash · 2024-09-10T14:22:28Z

@magento run all tests

app/code/Magento/Csp/Model/Mode/ConfigManager.php

Den4ik · 2024-09-10T14:53:16Z

@magento run all tests

Den4ik · 2024-09-10T17:46:54Z

@magento run Unit Tests

engcom-Dash · 2024-09-11T05:58:14Z

@magento run all tests

Den4ik

✅ Approved.
Changes looks ok for me.
Failed tests each time are different and don't related to the changes.

engcom-Dash · 2024-09-19T12:23:16Z

@magento run all tests

engcom-Dash · 2024-09-19T14:03:46Z

Hello @pmzandbergen

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:
Install fresh Magento 2.4-develop

Steps to reproduce

Create a new plugin on method: Magento\Csp\Model\Mode\Data\ModeConfigured::isReportOnly()
Set a breakpoint in the plugin's method or use the die keyword.
Access the homepage URL or admin page URL.

Before: ✖️
homepage loads without triggering the plugin.

After: ✔️
Plugin is triggered.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

engcom-Dash · 2024-09-20T10:44:33Z

@magento run all tests

engcom-Dash · 2024-09-20T13:59:49Z

I have a green build (all tests passed), so I'm moving it to Merge in Progress.

engcom-Dash · 2024-11-25T13:57:39Z

We have seen static failures in mainline PR after merging this PR into that. Hence for now moving this PR to Extended testing.

engcom-Dash · 2024-11-25T14:01:49Z

@magento run all tests

engcom-Dash · 2024-11-25T14:02:40Z

@magento run all tests

engcom-Dash · 2024-11-26T05:43:26Z

@magento run Functional Tests CE, Functional Tests B2B

engcom-Dash · 2024-11-26T09:18:05Z

The Functional B2B and CE test failures seem flaky and some of these failures are known issues. They are neither part of PR nor failing because of PR changes. Hence moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38886/6f2db52807a3c708a0be9960115b0689/Functional/allure-report-b2b/index.html#categories/3a3a8306986cbb01e5245b23e6e5b238/715420361f789b7/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38886/37b223604492bd6d8496120f6e64de42/Functional/allure-report-b2b/index.html#categories/3a3a8306986cbb01e5245b23e6e5b238/1b73508e9f000b5f/

Known Issues:
MultiShippingWithCreationNewCustomerAndAddressesDuringCheckoutTest: ACQE-7229
StoreFrontAddOutOfStockProductToShoppingCartTestCest: ACQE-6818
StorefrontReuseCouponCodeAfterOrderCanceledTest: ACQE-7230

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38886/42b5eb56906513fe5eea7fe14dd341e3/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/93d477020fb48965/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38886/974ba1a9f4df8f43176d877447c86fcf/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/7b4b2f91ca0a480a/

Known Issue:
VerifyDefaultWYSIWYGToolbarOnProductTest: ACQE-7227

fix: Use Object Manager for ModeConfigured

8b2069b

Fixing magento#38875 (AC-12299)

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jun 27, 2024

fix: Wrong type

44392fb

pmzandbergen added 3 commits June 27, 2024 19:23

Merge branch '2.4-develop' into patch-11

f3352f4

Merge branch '2.4-develop' into patch-11

2e1df4e

Merge branch '2.4-develop' into patch-11

38a7f3b

pmzandbergen mentioned this pull request Jul 3, 2024

Object Manager not used for Magento\Csp\Model\Mode\Data\ModeConfigured #38875

Closed

Merge branch '2.4-develop' into patch-11

40ba04e

Den4ik requested changes Jul 8, 2024

View reviewed changes

app/code/Magento/Csp/Model/Mode/ConfigManager.php Outdated Show resolved Hide resolved

m2-community-project bot assigned Den4ik Jul 8, 2024

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Jul 8, 2024

pmzandbergen and others added 2 commits July 8, 2024 14:06

fix: Type casting (reportOnly flag)

96daecf

Co-authored-by: Denis Kopylov <[email protected]>

fix: type casting (reportUri)

3d47ec0

Merge branch '2.4-develop' into patch-11

b0655ff

Den4ik requested changes Jul 18, 2024

View reviewed changes

app/code/Magento/Csp/Model/Mode/ConfigManager.php Outdated Show resolved Hide resolved

pmzandbergen added 2 commits July 18, 2024 17:07

fix: Optional parameter for constructor (backwards compatible)

7429a63

Merge branch '2.4-develop' into patch-11

50de528

pmzandbergen requested a review from Den4ik September 10, 2024 13:57

Den4ik reviewed Sep 10, 2024

View reviewed changes

app/code/Magento/Csp/Model/Mode/ConfigManager.php Outdated Show resolved Hide resolved

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 10, 2024

Update app/code/Magento/Csp/Model/Mode/ConfigManager.php

91905de

Merge branch '2.4-develop' into patch-11

198897c

engcom-Dash self-assigned this Sep 11, 2024

Den4ik approved these changes Sep 11, 2024

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Sep 11, 2024

Merge branch '2.4-develop' into patch-11

6214f97

38886: Fix failing unit test

1563e71

engcom-Dash and others added 2 commits November 25, 2024 19:30

38886: fix static failures

cbd4991

Merge branch '2.4-develop' into patch-11

bcb6d69

engcom-Dash added Progress: accept and removed Progress: ready for testing labels Nov 26, 2024

magento-devops-reposync-svc merged commit a0b4e0a into magento:2.4-develop Dec 24, 2024
10 of 12 checks passed

fix: Use Object Manager for ModeConfigured #38886

fix: Use Object Manager for ModeConfigured #38886

Uh oh!

Conversation

pmzandbergen commented Jun 27, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jun 27, 2024

Uh oh!

pmzandbergen commented Jun 27, 2024

Uh oh!

Den4ik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Den4ik commented Jul 8, 2024

Uh oh!

Den4ik commented Jul 8, 2024

Uh oh!

Den4ik commented Jul 9, 2024

Uh oh!

Den4ik commented Jul 11, 2024

Uh oh!

Den4ik commented Jul 15, 2024

Uh oh!

pmzandbergen commented Jul 16, 2024

Uh oh!

Den4ik commented Jul 16, 2024

Uh oh!

Den4ik commented Jul 16, 2024

Uh oh!

Den4ik commented Jul 18, 2024

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

engcom-Dash commented Sep 10, 2024

Uh oh!

Uh oh!

Den4ik commented Sep 10, 2024

Uh oh!

Den4ik commented Sep 10, 2024

Uh oh!

engcom-Dash commented Sep 11, 2024

Uh oh!

Den4ik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-Dash commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Sep 20, 2024

Uh oh!

engcom-Dash commented Sep 20, 2024

Uh oh!

engcom-Dash commented Nov 25, 2024

Uh oh!

engcom-Dash commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Nov 25, 2024

Uh oh!

engcom-Dash commented Nov 26, 2024

Uh oh!

engcom-Dash commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Den4ik left a comment •

edited

Loading

Den4ik left a comment •

edited

Loading

engcom-Dash commented Sep 19, 2024 •

edited

Loading

engcom-Dash commented Nov 25, 2024 •

edited

Loading

engcom-Dash commented Nov 26, 2024 •

edited

Loading