AC-12731 Issue#39020 Rendering the critical css inline event via csp … #39040

Mohamed-Asar · 2024-08-13T16:04:12Z

Description (*)

Rendering the critical css inline event via csp inline secure render

Fixed Issues (if relevant)

Fixes CSP issues combined with dev/css/use_css_critical_path #39020

Manual testing scenarios (*)

Enable dev/css/use_css_critical_path in order to facilitate critical CSS functionality
Add some items to cart
Visit checkout page

…inline secure render

m2-assistant · 2024-08-13T16:04:17Z

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Hotel · 2024-09-18T07:38:46Z

@magento run all tests

engcom-Hotel

Hello @Mohamed-Asar,

Thanks for the contribution!

Please make the changes as suggested below.

Thanks

engcom-Hotel · 2024-09-18T08:02:25Z

app/code/Magento/Theme/Controller/Result/AsyncCssPlugin.php

-    {
+    public function __construct(
+        ScopeConfigInterface $scopeConfig,
+        InlineUtilInterface $cspInlineUtil


New Params in Constructor should be null and handle it with ObjectManager

@engcom-Hotel Changes done. please check

….com/Mohamed-Asar/magento2 into bug/AC-12731-csp-inline-critical-css

engcom-Hotel · 2024-09-18T13:20:15Z

@magento run all tests

engcom-Charlie · 2024-09-19T06:13:45Z

It seems that review changes has been covered so moved it back to review

engcom-Hotel · 2024-09-20T07:28:30Z

@magento run Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests

engcom-Bravo · 2024-09-23T05:37:33Z

@magento run all tests

engcom-Bravo · 2024-09-23T08:01:26Z

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Enable dev/css/use_css_critical_path in order to facilitate critical CSS functionality
Add some items to cart
Visit checkout page

Before: ✖️

After: ✔️

Checkout pages are rendered with proper css styles

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

engcom-Charlie · 2024-09-23T09:19:18Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests, Unit Tests

engcom-Charlie · 2024-09-25T07:52:43Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests, Unit Tests

engcom-Charlie · 2024-09-26T06:39:58Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests, Unit Tests

engcom-Charlie · 2024-09-26T09:42:09Z

@magento run all tests

….com/Mohamed-Asar/magento2 into bug/AC-12731-csp-inline-critical-css

Mohamed-Asar · 2024-09-26T14:26:39Z

@engcom-Charlie I fixed the unit cases issue

Mohamed-Asar · 2024-09-26T14:26:59Z

@magento run all tests

Mohamed-Asar · 2024-09-27T07:05:10Z

@magento run Functional Tests B2B, Functional Tests EE, Static Tests

Mohamed-Asar · 2024-09-27T09:40:54Z

@magento run Static Tests

Mohamed-Asar · 2024-09-27T13:08:22Z

@magento run all tests

engcom-Charlie · 2024-09-30T06:39:33Z

@magento run Functional Tests B2B, Functional Tests EE, Static Tests

engcom-Charlie · 2024-09-30T09:02:17Z

@magento run all tests

engcom-Charlie · 2024-09-30T12:34:56Z

@magento run Functional Tests CE

engcom-Charlie · 2024-09-30T12:40:55Z

@magento run Functional Tests EE, Functional Tests B2B

engcom-Charlie · 2024-10-01T06:56:39Z

The functional B2B failures are not consistent in recent 2 builds. They are neither failing because of PR changes nor part of it. Considering them flaky.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39040/19e86db46db2fb9a04191525e3bca7ec/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39040/67cd301cc12b89e8cc9cff6f7b6a2aa6/Functional/allure-report-b2b/index.html#categories

bigbangx · 2025-02-24T16:59:48Z

Hello,
Not sure if that's what you expected, but it's good to mention that, as $useUnsafeHashes is false by defalut in Magento\Csp\Helper\InlineUtil , this code will set unsafe-inline on script-src for all pages with critical css !

AC-12731 Issue#39020 Rendering the critical css inline event via csp …

a8bbf25

…inline secure render

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 13, 2024

m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Aug 13, 2024

m2-community-project bot added Progress: pending review labels Aug 13, 2024

Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024

Merge branch '2.4-develop' into bug/AC-12731-csp-inline-critical-css

128a5d0

engcom-Hotel requested changes Sep 18, 2024

View reviewed changes

m2-community-project bot assigned engcom-Hotel Sep 18, 2024

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Sep 18, 2024

Mohamed-Asar added 2 commits September 18, 2024 17:43

AC-12731 Constructor changes and removed unused import

03498bb

Merge branch 'bug/AC-12731-csp-inline-critical-css' of https://github…

8b90d5d

….com/Mohamed-Asar/magento2 into bug/AC-12731-csp-inline-critical-css

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 18, 2024

engcom-Charlie requested a review from engcom-Hotel September 19, 2024 06:13

engcom-Hotel approved these changes Sep 20, 2024

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Sep 20, 2024

Merge branch '2.4-develop' into bug/AC-12731-csp-inline-critical-css

dcd290e

engcom-Charlie self-assigned this Sep 23, 2024

Fixed Static test failure

f523351

Merge branch '2.4-develop' into bug/AC-12731-csp-inline-critical-css

ddf19b1

Update composer.json to fix static test failures

5aac5ba

Mohamed-Asar added 2 commits September 26, 2024 19:55

Unit test case fix

ba9a00b

Merge branch 'bug/AC-12731-csp-inline-critical-css' of https://github…

cf0d4b4

….com/Mohamed-Asar/magento2 into bug/AC-12731-csp-inline-critical-css

Composer dependency added

014a9af

Fixed static test failure

107eafc

Merge branch '2.4-develop' into bug/AC-12731-csp-inline-critical-css

751f00e

magento-devops-reposync-svc merged commit 5c24c15 into magento:2.4-develop Oct 18, 2024
11 of 12 checks passed

AC-12731 Issue#39020 Rendering the critical css inline event via csp … #39040

AC-12731 Issue#39020 Rendering the critical css inline event via csp … #39040

Uh oh!

Conversation

Mohamed-Asar commented Aug 13, 2024

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Uh oh!

m2-assistant bot commented Aug 13, 2024

Uh oh!

engcom-Hotel commented Sep 18, 2024

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Sep 18, 2024

Uh oh!

engcom-Charlie commented Sep 19, 2024

Uh oh!

engcom-Hotel commented Sep 20, 2024

Uh oh!

engcom-Bravo commented Sep 23, 2024

Uh oh!

engcom-Bravo commented Sep 23, 2024

✔️ QA Passed

Uh oh!

engcom-Charlie commented Sep 23, 2024

Uh oh!

engcom-Charlie commented Sep 25, 2024

Uh oh!

engcom-Charlie commented Sep 26, 2024

Uh oh!

engcom-Charlie commented Sep 26, 2024

Uh oh!

Mohamed-Asar commented Sep 26, 2024

Uh oh!

Mohamed-Asar commented Sep 26, 2024

Uh oh!

Mohamed-Asar commented Sep 27, 2024

Uh oh!

Mohamed-Asar commented Sep 27, 2024

Uh oh!

Mohamed-Asar commented Sep 27, 2024

Uh oh!

engcom-Charlie commented Sep 30, 2024

Uh oh!

engcom-Charlie commented Sep 30, 2024

Uh oh!

engcom-Charlie commented Sep 30, 2024

Uh oh!

engcom-Charlie commented Sep 30, 2024

Uh oh!

engcom-Charlie commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bigbangx commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

engcom-Charlie commented Oct 1, 2024 •

edited

Loading

bigbangx commented Feb 24, 2025 •

edited

Loading