Skip to content

[PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface #39199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 7, 2025
Merged

[PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface #39199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
689812b
Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface
Sep 23, 2024
632f588
Rollback addBreadcrumb
Sep 23, 2024
8e329a8
Merge branch '2.4-develop' into phpdoc/scopeConfig
dimitriBouteille Sep 27, 2024
a9d0893
Merge branch '2.4-develop' into phpdoc/scopeConfig
engcom-Hotel Dec 13, 2024
33ba280
Merge branch '2.4-develop' into phpdoc/scopeConfig
engcom-Dash Dec 16, 2024
7954b26
39199: fix static failures
engcom-Dash Dec 16, 2024
cf6e875
Fix review
Dec 16, 2024
8c8dd99
Merge branch '2.4-develop' into phpdoc/scopeConfig
dimitriBouteille Dec 16, 2024
aa0fabc
Merge branch '2.4-develop' into phpdoc/scopeConfig
engcom-Dash Dec 18, 2024
d435d88
Merge branch '2.4-develop' into phpdoc/scopeConfig
dimitriBouteille Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions lib/internal/Magento/Framework/App/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php
/**
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2013 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\App;

use Magento\Framework\App\Config\ConfigTypeInterface;
Expand Down Expand Up @@ -45,12 +45,7 @@ public function __construct(
}

/**
* Retrieve config value by path and scope
*
* @param string $path
* @param string $scope
* @param null|int|string $scopeCode
* @return mixed
* @inheritDoc
*/
public function getValue(
$path = null,
Expand Down Expand Up @@ -80,12 +75,7 @@ public function getValue(
}

/**
* Retrieve config flag
*
* @param string $path
* @param string $scope
* @param null|int|string $scopeCode
* @return bool
* @inheritDoc
*/
public function isSetFlag($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null)
{
Expand Down
12 changes: 5 additions & 7 deletions lib/internal/Magento/Framework/App/Config/ScopeConfigInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<?php
/**
* Configuration interface
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\App\Config;
Expand All @@ -17,14 +15,14 @@ interface ScopeConfigInterface
/**
* Default scope type
*/
const SCOPE_TYPE_DEFAULT = 'default';
public const SCOPE_TYPE_DEFAULT = 'default';

/**
* Retrieve config value by path and scope.
*
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
* @param null|int|string $scopeCode
* @param null|int|string|\Magento\Framework\App\ScopeInterface $scopeCode
* @return mixed
*/
public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);
Expand All @@ -34,7 +32,7 @@ public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DE
*
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
* @param null|int|string $scopeCode
* @param null|int|string|\Magento\Framework\App\ScopeInterface $scopeCode
* @return bool
*/
public function isSetFlag($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);
Expand Down