-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Restores backwards compatibility with TinyMCE plugins again (after it… #39258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @hostep. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run Unit Tests |
TinyMCE7 is GPL, I don't undestand how this update was pushed #39252 |
Yes yes, that's a completely different issue, and I was already aware of that, please give the legal team of Adobe some time to look into it and they'll get back with an answer hopefully. |
@magento create issue |
@magento run all tests |
Hello @hostep, Thanks for the contribution! We need to put this PR on Let once roll back the tinyMCE and accordingly, we will pick this PR. Thanks |
… broke with introduction of TinyMCE7).
47b1b99
to
a71df16
Compare
@engcom-Hotel: Now that TinyMCE was downgraded from v7 to v6 in 09c82b1, I re-tested the issue and the problem still happens. I also re-tested my fix and it still fixes the issue. I re-based my fix on the latest 2.4-develop branch and force pushed it. So this can be picked up again. Thanks! @magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE, Static Tests |
…nymce-plugins-after-upgrade-to-tinymce7
@magento run all tests |
Hi @hostep, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️ ![]() After: ✔️ ![]() Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
1 similar comment
@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
787a020
into
magento:2.4-develop
… broke with introduction of TinyMCE7).
Description (*)
Magento comes with 2 new TinyMCE plugins by default:
Recently, with the switch from TinyMCE v5 to v7 in the latest security patch releases (2.4.7-p3, ...) and 2.4.8-beta1, those plugins got rewritten to adhere to the new system in TinyMCE 7. However, a big mistake was made by not returning the widgets as an object, which meant that you couldn't call the functions defined inside the plugin anymore when trying to use the widget from another location.
Example with magentowidget, old version vs new version, note that in the new version there is no object being returned in that
magentowidget
function anymore.This resulted in this error output when trying to call the
encodeWidgets
on themagentowidget
instance, because that last one was just an empty object:This PR fixes that.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
That last step will fail and you'll see an error in your browser's console. This PR fixes this issue.
Questions or comments
Adding automated tests for this will be hard, so I'm not doing it, hopefully that's okay, if not, please write them yourselves, I won't have the time to put into this task.
Contribution checklist (*)
Resolved issues: