Skip to content

Self hosted support #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Self hosted support #130

wants to merge 3 commits into from

Conversation

@sameagen-MW
Copy link
Member

Addressing the call to chmod on Windows, and adding ARM Macs as a supported platform / architecture pair in run-matlab-command.

@sameagen-MW sameagen-MW marked this pull request as draft August 28, 2024 18:51
@sameagen-MW sameagen-MW marked this pull request as ready for review August 28, 2024 19:48
@sameagen-MW
Copy link
Member Author

Hard to test whether it's fully working on Windows with that mpm bug, but it seems to be doing everything else correctly. We might need to hold off on documenting windows support though until that bug gets resolved, because it seems to be unuseable (at least for the Windows version installed on my laptop)

davidbuzinski
davidbuzinski approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@davidbuzinski davidbuzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think something strange is happening with the templates we use for our existing "self-hosted" tests. It would be nice at some point to add more tests to also test the InstallMatlab task on our own managed runners.

@mcafaro
Copy link
Member

mcafaro commented Aug 29, 2024

Looks good! I think something strange is happening with the templates we use for our existing "self-hosted" tests. It would be nice at some point to add more tests to also test the InstallMatlab task on our own managed runners.

One idea is to use a GitHub-hosted runner and strip it of things we don't expect a self-hosted runner to have (like bash).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidbuzinski davidbuzinski davidbuzinski approved these changes

Assignees

@mw-hrastega mw-hrastega

@yitingw3 yitingw3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sameagen-MW @mcafaro @davidbuzinski @mw-hrastega @yitingw3