Update run-matlab-command compression #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension into update-rmc-compression
davidbuzinski
changed the title
mcafaro
approved these changes
Oct 9, 2024
sameagen-MW
approved these changes
Oct 9, 2024
Comment on lines
+17
to
+19
| tr.registerMock("fs", { | ||
| chmodSync: () => Promise.resolve(0), | ||
| }); |
There was a problem hiding this comment.
Huh, was this failing before? Or did it just work even with that not mocked out?
There was a problem hiding this comment.
It was working. It was just operating on the actual file. This time the file didn't exist (because it needs to be unzipped) so it was failing. I wanted to make sure our tests don't ever actually unzip anything so we don't accidentally ship both the zip and the unzipped binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is so that we no longer rely on
upxto compress therun-matlab-commandbinary. We were doing this in order to get our extension below the size limit to publish on the marketplace.It is updated to zip all of the run-matlab-command binaries that we ship in the extension. During all of the "run" steps, we will unzip the binary if it hasn't already been unzipped. It adds a small amount of overhead and maintenance, but ensures that we do not add any further external dependencies onto the runner for our Tasks.
I am also commenting out the failing parallel tests steps until the issue mentioned in the comment is resolved.