Skip to content

Change default interpolation to nearest #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jenshnielsen
Copy link
Member

#4622 agains 2.0.x

@jenshnielsen
Copy link
Member Author

There is something seriously wrong somewhere

This causes matplotlib.tests.test_image.test_get_window_extent_for_AxisImage to segfault at least on python 3.5

@jenshnielsen
Copy link
Member Author

Furthermore a fair number of tests fail due to the change. They don't seem to pickup the classic style

@mdboom
Copy link
Member

mdboom commented Nov 6, 2015

I don't think the test suite has been set up to forcibly use the classic style yet.

@jenshnielsen
Copy link
Member Author

Ok the seqfault is genuine thou

@jenshnielsen
Copy link
Member Author

I thought this was supposed to set it up to use the classic style https://github.com/matplotlib/matplotlib/blob/v2.0.x/lib/matplotlib/testing/decorators.py#L232

@WeatherGod
Copy link
Member

It was set up to use the classic style for any image comparison test.
Something is wrong if it isn't doing that.

On Fri, Nov 6, 2015 at 9:33 AM, Jens Hedegaard Nielsen <
[email protected]> wrote:

I thought this was supposed to set it up to use the classic style
https://github.com/matplotlib/matplotlib/blob/v2.0.x/lib/matplotlib/testing/decorators.py#L232


Reply to this email directly or view it on GitHub
#5416 (comment)
.

@mdboom
Copy link
Member

mdboom commented Nov 6, 2015

Sorry, I missed that. I was expecting to see that in the cleanup decorator, not the image comparison one.

@jenshnielsen
Copy link
Member Author

The segfault is on master too https://travis-ci.org/matplotlib/matplotlib/jobs/89776539
see #5429

@jenshnielsen jenshnielsen force-pushed the default_interpolation branch from dd2cb75 to 7357f1b Compare November 8, 2015 14:40
@jenshnielsen
Copy link
Member Author

rebased to fix the segfault

mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 8, 2015
@mdboom mdboom mentioned this pull request Nov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 11, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 13, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull request Nov 16, 2015
@tacaswell tacaswell closed this Dec 19, 2015
@tacaswell
Copy link
Member

@mdboom is this folded into your style branch?

@mdboom
Copy link
Member

mdboom commented Dec 22, 2015

@mdboom is this folded into your style branch?

Yes. And related to this (for the record) I think we should also set image.resample to True by default (see the discussion in #5718)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants