-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Change default interpolation to nearest #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default interpolation to nearest #5416
Conversation
There is something seriously wrong somewhere This causes matplotlib.tests.test_image.test_get_window_extent_for_AxisImage to segfault at least on python 3.5 |
Furthermore a fair number of tests fail due to the change. They don't seem to pickup the classic style |
I don't think the test suite has been set up to forcibly use the classic style yet. |
Ok the seqfault is genuine thou |
I thought this was supposed to set it up to use the classic style https://github.com/matplotlib/matplotlib/blob/v2.0.x/lib/matplotlib/testing/decorators.py#L232 |
It was set up to use the classic style for any image comparison test. On Fri, Nov 6, 2015 at 9:33 AM, Jens Hedegaard Nielsen <
|
Sorry, I missed that. I was expecting to see that in the cleanup decorator, not the image comparison one. |
The segfault is on master too https://travis-ci.org/matplotlib/matplotlib/jobs/89776539 |
dd2cb75
to
7357f1b
Compare
rebased to fix the segfault |
Hopefully fixes failures in matplotlib#5416
Hopefully fixes failures in matplotlib#5416
Hopefully fixes failures in matplotlib#5416
Fix failures in matplotlib#5416
Fix failures in matplotlib#5416
Fix failures in matplotlib#5416
Fix failures in matplotlib#5416
@mdboom is this folded into your style branch? |
#4622 agains 2.0.x