Skip to content

Conversation

@afvincent
Copy link
Contributor

Clean up of pylab_examples/demo_annotation_box.py:

  • moves all imports to the head of the script;
  • reorganizes and adds comments to make the different steps more obvious;
  • removes the final plt.draw call;
  • loads Grace Hopper's portrait with plt.imread instead of _png.read_png, which (at least) avoids an additional import (besides, is the _png supposed to be exposed in a pylab example?).

@tacaswell tacaswell modified the milestone: 2.0 (style change major release) Jul 16, 2016
@afvincent
Copy link
Contributor Author

It looks to me that the Travis pep8 failure is not related the current PR (the incriminated file is test_backend_svg.py…), but tell me if I'm wrong and I will re-check the pep8-ness of the file I've modified.

@WeatherGod
Copy link
Member

yeah, the fix for that is in master now, so don't fret it.

@WeatherGod WeatherGod merged commit 2f2b08d into matplotlib:master Jul 16, 2016
tacaswell pushed a commit that referenced this pull request Jul 16, 2016
DOC: clean up of demo_annotation_box.py
@tacaswell
Copy link
Member

backported to v2.x as 6b3622a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants