BUG: 'saving' context manager now passes all args, kw to setup. #7207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the functionality added to master in 6bac790 (matplotlib#6304). Directly cherry-picking that is not possible because of the intervening introduction of abstract base classes.
Member
Author
|
If and when this is merged into v2.x, it will cause a conflict when merging v2.x into master. The solution is to accept the version of animation.py from master with no changes. |
Member
|
Thanks @efiring ! |
Member
Author
|
I have merged v2.x into master, resolving the conflict as described earlier. 7b27a1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the functionality added to master in 6bac790 (#6304).
Directly cherry-picking that is not possible because of the intervening
introduction of abstract base classes.