Skip to content

Don't read full cube into mem for histogramming #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually don't read all bins into memory...
  • Loading branch information
dstansby committed Jul 26, 2023
commit 1aa3efd13a57d0dc5ddd2b09af058bc27a125f9c
2 changes: 1 addition & 1 deletion src/napari_matplotlib/histogram.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def draw(self) -> None:

# Important to calculate bins after slicing 3D data, to avoid reading
# whole cube into memory.
bins = np.linspace(np.min(layer.data), np.max(layer.data), 100)
bins = np.linspace(np.min(data), np.max(data), 100)

if layer.rgb:
# Histogram RGB channels independently
Expand Down