Skip to content

Use integer bins for integer data in HistogramWidget #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 15, 2024
Prev Previous commit
Next Next commit
ensure histogram bin step size is always a positive integer
  • Loading branch information
p-j-smith committed Jan 15, 2024
commit 14121492690b46bffb0aa7d05082d3ea86e8f120
2 changes: 1 addition & 1 deletion src/napari_matplotlib/histogram.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def draw(self) -> None:
# whole cube into memory.
if data.dtype.kind in {"i", "u"}:
# Make sure integer data types have integer sized bins
step = 1 + (np.max(data) - np.min(data)) // 100
step = 1 + abs(np.max(data) - np.min(data)) // 100
bins = np.arange(np.min(data), np.max(data) + step, step)
else:
bins = np.linspace(np.min(data), np.max(data), 100)
Expand Down