Skip to content

Only update layers when selection is valid #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Only update layers when selection is valid #260

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70dc256
Only update layers when selection is valid
dstansby May 3, 2024
72e5791
Only set colors if x_axis_key is string
dstansby May 25, 2024
2874081
Debugging
dstansby May 25, 2024
3ebea2f
Put self._draw() in clause
dstansby May 25, 2024
b01809f
Always call on_update_layers
dstansby Jul 12, 2024
8a54595
Fix layer selection
dstansby Jul 12, 2024
25b9b0e
Update changelog
dstansby Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Debugging
  • Loading branch information
@dstansby
dstansby committed Jul 12, 2024
commit 2874081c869b32b17977c4df54a7267d59a9a286
4 changes: 4 additions & 0 deletions src/napari_matplotlib/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ def _valid_layer_selection(self) -> bool:
"""
Return `True` if layer selection is valid.
"""
print(f"{self.n_selected_layers=}")
print(f"{self.n_layers_input=}")
print(f"{self.layers=}")
print(f"{self.input_layer_types=}")
return self.n_selected_layers in self.n_layers_input and all(
isinstance(layer, self.input_layer_types) for layer in self.layers
)
Expand Down