Skip to content

Reference for JS magic comments - #45838

Merged
Josh-Cena merged 5 commits into
mdn:mainfrom
Josh-Cena:magic-comments
Oct 2, 2026
Merged

Josh-Cena merged 5 commits into
mdn:mainfrom
Josh-Cena:magic-comments

Conversation

@Josh-Cena

Copy link
Copy Markdown
Member

@Josh-Cena
Josh-Cena requested review from a team as code owners September 24, 2026 22:10
@Josh-Cena
Josh-Cena requested review from chrisdavidmills and pepelsbey and removed request for a team September 24, 2026 22:10
@github-actions github-actions Bot added Content:JS JavaScript docs system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Preview URLs (1 page)

External URLs (18)

URL: /en-US/docs/Web/JavaScript/Reference/Magic_comments
Title: Magic comments

(comment last updated: 2026-09-29 15:45:39)

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Josh-Cena; I found this interesting and informative to read. I've left you a few nitpicks to check over. I'll also ask Marja to give this a tech review.

Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
@Josh-Cena

Copy link
Copy Markdown
Member Author

Wow, looks like I wrote an embarrassing amount of typos. Definitely not sleeping well.

Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated
Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from an editorial standpoint; approving.

I'll hold off on merging to see if we can get a tech review on this. Maybe you could merge it in a few days if you don't hear anything?

@Josh-Cena

Copy link
Copy Markdown
Member Author

Alright 👍 Have you pinged anyone to do tech review?

@chrisdavidmills

Copy link
Copy Markdown
Contributor

Alright 👍 Have you pinged anyone to do tech review?

Yes, I emailed @marjakh to ask if she'd have a look. I guess I've pinged her here now too ;-)

@Josh-Cena

Copy link
Copy Markdown
Member Author

OK! I'll hold this until Friday.

Comment thread files/en-us/web/javascript/reference/magic_comments/index.md Outdated

@marjakh marjakh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the parts about compile hints; comments inline

@Josh-Cena

Copy link
Copy Markdown
Member Author

I'll merge in the next 24 hours if everything looks good—thanks!

@Josh-Cena

Copy link
Copy Markdown
Member Author

Merging. Thanks both!

@Josh-Cena
Josh-Cena merged commit cd2f1ce into mdn:main Oct 2, 2026
11 checks passed
@Josh-Cena
Josh-Cena deleted the magic-comments branch October 2, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants