Reference for JS magic comments - #45838
Conversation
chrisdavidmills
left a comment
There was a problem hiding this comment.
Nice work, @Josh-Cena; I found this interesting and informative to read. I've left you a few nitpicks to check over. I'll also ask Marja to give this a tech review.
|
Wow, looks like I wrote an embarrassing amount of typos. Definitely not sleeping well. |
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
chrisdavidmills
left a comment
There was a problem hiding this comment.
This looks good to me from an editorial standpoint; approving.
I'll hold off on merging to see if we can get a tech review on this. Maybe you could merge it in a few days if you don't hear anything?
|
Alright 👍 Have you pinged anyone to do tech review? |
Yes, I emailed @marjakh to ask if she'd have a look. I guess I've pinged her here now too ;-) |
|
OK! I'll hold this until Friday. |
marjakh
left a comment
There was a problem hiding this comment.
I only looked at the parts about compile hints; comments inline
|
I'll merge in the next 24 hours if everything looks good—thanks! |
|
Merging. Thanks both! |
As tracked by the Google team.