-
Notifications
You must be signed in to change notification settings - Fork 21
Use Elasticsearch 2.x client and update some params #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
the examples as are in this branch give an error (the requests produce a 400 error), the code before the change is also not up to date, but let's make sure it all works perfectly before we merge it. |
|
looks like my bad on the 400. |
mickeyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are ok.
as a follow up we should rework the outputs.
|
I don't know if this helps, but |
|
Thanks @zmughal. I did not know about that filter. Are you saying we should use it in some of the examples? |
|
Thanks @zmughal I don't have a problem with the Maybe we should just turn off the tracing? I don't think it should be part of the output (maybe only turn it on by a special debugging param) |
Just sent in PR #24 as an attempt at that. |
POSTfavorite