Skip to content

Merging uaiohttpclient #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfalcon opened this issue Feb 5, 2017 · 2 comments
Closed

Merging uaiohttpclient #148

pfalcon opened this issue Feb 5, 2017 · 2 comments

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Feb 5, 2017

I looked thru my repos and saw https://github.com/pfalcon/micropython-uaiohttpclient which I almost forgot about. So, I propose to merge it into micropython-lib. It's also the easiest way to achieve its installability on esp8266 (gzip-4k packing).

@dpgeorge ^

@dpgeorge
Copy link
Member

dpgeorge commented Feb 6, 2017

I saw there is a asyncio version of requests https://github.com/rdbhost/yieldfromRequests, and it would be nice to support/promote a consistent set of libraries, eg both requests and it's yield-from version. OTOH, aiohttp looks better maintained than yieldfromRequests, and has more github stars, so perhaps aiohttp is the one we should use.

pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue Nov 3, 2017
Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .
@pfalcon
Copy link
Contributor Author

pfalcon commented Nov 26, 2017

Imported.

@pfalcon pfalcon closed this as completed Nov 26, 2017
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue Feb 1, 2018
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue May 3, 2020
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue May 3, 2020
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants