aioble: Fix notified/indicated event waiting. #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a client does a successful `await char.notified()`, then before the next call to `notified()` a notification arrives, then they call `notified()` twice before the _next_ notification, the second call will return None rather than waiting. This applies the same fix as in 5a86aa5 which solved a similar problem for server-side `char.written()`. Using a deque is slightly overkill here, but it's consistent with the server side, and also makes it very easy to support having a notification queue in the future. Also makes the client characteristic properly flags/properties-aware (i.e. explicitly fail operations that aren't supported). Signed-off-by: Jim Mussared <[email protected]>
This allows a server to write a characteristic and automatically notify/indicate all subscribed clients. Signed-off-by: Jim Mussared <[email protected]>
jimmo
added a commit
to jimmo/micropython-lib
that referenced
this pull request
Nov 10, 2021
This replicates the failure described in micropython#453 (which is fixed by micropython#459. Also adds a test for subscription. Signed-off-by: Jim Mussared <[email protected]>
This replicates the failure described in micropython#453 (which is fixed by micropython#459. Also adds a test for subscription. Signed-off-by: Jim Mussared <[email protected]>
jimmo
force-pushed
the
notified-event
branch
from
d63d821 to
dd9b783
Compare
|
Added multitest for this. Also added multitest for subscription (so I've pulled in the commit from #437). |
|
Thank you! The multitests pass for me on PYBD+PYBD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a client does a successful
await char.notified(), then before thenext call to
notified()a notification arrives, then they callnotified()twice before the next notification, the second call willreturn None rather than waiting.
This applies the same fix as in 5a86aa5
which solved a similar problem for server-side
char.written(). Usinga deque is slightly overkill here, but it's consistent with the server
side, and also makes it very easy to support having a notification queue
in the future.
Also makes the client characteristic properly flags/properties-aware (i.e.
explicitly fail operations that aren't supported).
Signed-off-by: Jim Mussared [email protected]