T naabus/textfixing #106

t-naabus · 2016-11-28T16:50:41Z

Text Scrubbing

…werBI-JavaScript into t-naabus/textfixing

…into t-naabus/textfixing

msftclas · 2016-11-28T16:50:45Z

Hi @t-naabus, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Najib Abu Samra). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

noanu · 2016-11-28T18:33:50Z

demo/code-demo/step_authorize.html

        <ul>
-            <li>A workspace in <a href="https://azure.microsoft.com/en-us/documentation/articles/power-bi-embedded-get-started/">Azure PowerBI Embedded Service.</a></li>
-            <li>PowerBI Report imported to your workspace.</li>
+            <li>A workspace in the <a href="https://azure.microsoft.com/en-us/documentation/articles/power-bi-embedded-get-started/">Power BI embedded service.</a></li>


you write Power BI (as separated words) above, and PowerBI as one word below.... Please make sure it is consistent.

thanks, missed one

ranbreuer · 2016-11-28T19:36:31Z

demo/code-demo/step_authorize.html

-    <button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed Sample Report</button><br/><br/><br/>
-    <a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
+    <h4>Sample report</h4>
+    To embed using a report supplied with the sample, select <b>Embed sample report</b>.<br/>


Embed Sample Report

this is a command not a sentence

ranbreuer · 2016-11-28T19:36:47Z

demo/code-demo/step_authorize.html

-    To Embed using a sample report, you can just move to next step.<br/>
-    <button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed Sample Report</button><br/><br/><br/>
-    <a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
+    <h4>Sample report</h4>


Sample Report

Title not sentence

ranbreuer · 2016-11-28T19:37:20Z

demo/code-demo/report.html

        <div id="left-pane" class="halfWidth right">
            <div id="embedArea">
-                <h3>Embedded Report Area</h3>
+                <h3>Embedded report area</h3>


Embedded Report Area

title

ranbreuer · 2016-11-28T19:39:14Z

demo/code-demo/step_authorize.html

-        <h4>Flow</h4>
-        Once you have a report imported to PowerBI Workspace, you are ready to embed it.<br/>
-        To Embed a report you need to get an Embed-Token. You can create this token in multiple ways:<br/>
+        <h4>Instructions to get embed token</h4>


... generate an embed App Token

ranbreuer · 2016-11-28T19:40:02Z

demo/code-demo/step_authorize.html

-        Once you have a report imported to PowerBI Workspace, you are ready to embed it.<br/>
-        To Embed a report you need to get an Embed-Token. You can create this token in multiple ways:<br/>
+        <h4>Instructions to get embed token</h4>
+        Once you have a report imported to Power BI workspace, you are ready to embed it.<br/>


Once you have improted a report into Power BI...

ranbreuer · 2016-11-28T19:40:49Z

demo/code-demo/step_authorize.html

+        <h4>Instructions to get embed token</h4>
+        Once you have a report imported to Power BI workspace, you are ready to embed it.<br/>
+        <br/>
+        To embed a report, you need to get an embed-Token. You can create this token in multiple ways.<br/>


embed App Token

no hyphens
please be consistent

just following what I was sent

ranbreuer · 2016-11-28T19:41:18Z

demo/code-demo/step_authorize.html

+        <h4>Enter embed details</h4>

-        Enter Report Embed Token</br>
+        Enter report embed token<br/>


ranbreuer · 2016-11-28T19:45:30Z

demo/code-demo/step_authorize.html

        <input type="text" id="txtReportEmbed" name="txtReportEmbed" onchange="UpdateSessions();" style="width: 100%;" value="https://embedded.powerbi.com/appTokenReportEmbed" /><br/><br/>

-        Enter Report Id</br>
+        Enter report id<br/>


ranbreuer · 2016-11-28T19:45:39Z

demo/code-demo/step_authorize.html

        <input type="text" id="txtAccessToken" name="txtAccessToken" onchange="UpdateSessions();" style="width: 100%;" /><br/><br/>

-        Enter Report Embedded Url</br>
+        Enter report embedded url<br/>


ranbreuer · 2016-11-28T19:48:09Z

demo/code-demo/step_authorize.html

        <input type="text" id="txtEmbedReportId" name="txtEmbedReportId" onchange="UpdateSessions();" style="width: 100%;" /><br/>
    </div>
-    <button id="nextStep" class="btn btn-primary" onclick="OpenEmbedStep()">Next Step - Embed</button>
+    <button id="nextStep" class="btn btn-primary" onclick="OpenEmbedStep()">Next step - embed</button>


Embed

title

ranbreuer · 2016-11-28T19:48:18Z

demo/code-demo/step_embed.html

    <table id="report-embed-table">
        <tr>
-            <td class="td-field-name">Embed Token</td>
+            <td class="td-field-name">Embed token</td>


ranbreuer

Please run through one more time to make sure Caps are used correctly in titles and acronyms.

* Fixed small grammar issue * Update Index.cshtml

t-naabus added 9 commits November 28, 2016 17:06

build things

f343434

text fixed

f413e6e

text fixed

441e0d3

Merge branch 't-naabus/textfixing' of https://github.com/Microsoft/Po…

307cc61

…werBI-JavaScript into t-naabus/textfixing

text fixed

8b9dc5b

text fixed

32968df

Merge branch 'dev' of https://github.com/Microsoft/PowerBI-JavaScript …

64bab62

…into t-naabus/textfixing

merge

75bbc70

merge

605eb19

t-naabus assigned ranbreuer, noanu and ali-hamud Nov 28, 2016

msftclas added the documentation Improvements or additions to documentation label Nov 28, 2016

ali-hamud approved these changes Nov 28, 2016

View reviewed changes

noanu reviewed Nov 28, 2016

View reviewed changes

ranbreuer reviewed Nov 28, 2016

View reviewed changes

ranbreuer approved these changes Nov 28, 2016

View reviewed changes

Textfix fix

b4b0087

noanu approved these changes Nov 29, 2016

View reviewed changes

t-naabus merged commit cc78003 into dev Nov 29, 2016

t-naabus deleted the t-naabus/textfixing branch November 29, 2016 08:56

tenshi13 pushed a commit to tenshi13/PowerBI-JavaScript that referenced this pull request May 11, 2021

Fixed small grammar issue (microsoft#106)

97b88e1

* Fixed small grammar issue * Update Index.cshtml

T naabus/textfixing #106

T naabus/textfixing #106

Uh oh!

Conversation

t-naabus commented Nov 28, 2016

Uh oh!

msftclas commented Nov 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranbreuer Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranbreuer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ranbreuer Nov 28, 2016 •

edited

Loading