sample new design #114
Merged
sample new design #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ali-hamud
commented
Dec 8, 2016
ali-hamud
commented
- html and css changes
- if backend server for retrieving token is down, use backup embed token.
ranbreuer
reviewed
Dec 8, 2016
|
|
||
| LoadLogWindow("#logWindow"); | ||
|
|
||
| if (GetParameterByName("embedUrl") || GetParameterByName("embedId") || GetParameterByName("accessToken")) |
There was a problem hiding this comment.
No. I want to move to Embed step if one provided.
ranbreuer
approved these changes
Dec 8, 2016
tenshi13
pushed a commit
to tenshi13/PowerBI-JavaScript
that referenced
this pull request
May 11, 2021
Delete Embed Token Generation folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.