Skip to content

Add reset method to core service which checks for associated component and if found removes it from internal list, removes component, and removes iframe. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2016
Merged

Add reset method to core service which checks for associated component and if found removes it from internal list, removes component, and removes iframe. #14

merged 2 commits into from
Apr 26, 2016

Conversation

@mattmazzola
Copy link
Contributor

@mattmazzola mattmazzola commented Apr 25, 2016

Closes: #6

Add reset method to core service which removes checks for associated …
c31163d 
…component and if found removes it from internal list, removes component, and removes iframe.
@msftclas
Copy link

msftclas commented Apr 25, 2016

Hi @mattmazzola, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Matt Mazzola). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas msftclas added the documentation Improvements or additions to documentation label Apr 25, 2016
@mattmazzola mattmazzola added this to the GA milestone Apr 25, 2016
@wbreza
Copy link
Contributor

wbreza commented Apr 25, 2016

LGTM

mattmazzola
mattmazzola reviewed Apr 25, 2016
View reviewed changes
src/core.ts Outdated
Utils.remove(x => x === powerBiElement.powerBiEmbed, this.embeds);
/** Delete property from html element */
delete powerBiElement.powerBiEmbed;
/** Remove iframe from element by clearing innerHTML */
Copy link
Contributor Author

@mattmazzola mattmazzola Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update this comment. Will fix.

@mattmazzola mattmazzola merged commit 1f358a9 into master Apr 26, 2016
@mattmazzola mattmazzola deleted the dev/mattm/reset branch April 26, 2016 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wbreza wbreza

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

GA

Development

Successfully merging this pull request may close these issues.

4 participants

@mattmazzola @msftclas @wbreza