Mirror internal ADO #373
Merged
Mirror internal ADO #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add kjhtml to the Javascript SDK to make debugging tests easier. ## Know issues: 1) An old version (0.2.2) is used because newer versions are incompatible with our jasmine karma versions, trying to update them causes issues both in the tests themselves and in test coverage reporting. 2) Closing the test page doesn't close the running command in the terminal, need a couple of `cntrl + c`, this is the same in other repositories. For reference check [karma.baseconf.js](https://powerbi.visualstudio.com/PowerBIClients/_git/PowerBIClients?path=%2Fsrc%2FModern%2FIntegrationTesting%2FDesktopIntegrationTestHost%2Fkarma.baseconf.js&_a=contents&version=GBmaster) and [karma.conf.js](https://powerbi.visualstudio.com/PowerBIClients/_git/PowerBIClients?path=%2Fsrc%2FClients%2FPowerBIPlayground%2FAngular%2Fkarma.conf.js&_a=contents&version=GBmaster) 
There are currently about 2000 eslint warnings when running gulp build which slows the build time. This PR reduces that number to about 60 by doing the following things; - Run the automatic eslint fix - Ignore the test folder - Ignore several noisy rules - Fix imports Please let me know of any non-trivial change in this PR so I can revert it and make this PR simpler and safer. I recommend reviewing this with `Show and diff white space` unchecked
commit 53c1d1e Merge: b87e94d 039dd38 Author: ali-hamud <[email protected]> Date: Wed Dec 23 11:00:42 2020 +0200 Merge pull request #369 from guyinacube/videoupdate 👊 Update old content video commit b87e94d Merge: c87eb45 6a67f3b Author: ali-hamud <[email protected]> Date: Wed Dec 23 11:00:26 2020 +0200 Merge pull request #367 from snehaldalvi/bashwoman Spelling Corrected commit 039dd38 Author: Adam Saxton <[email protected]> Date: Wed Dec 2 15:13:38 2020 -0600 Update old content video commit 6a67f3b Author: Snehal <[email protected]> Date: Thu Oct 1 09:27:10 2020 +0530 Typo Changed Related work items: #351, #357, #366, #367, #369, #371, #372
Remove filterPaneEnabled from docs
…ters for visual API
Added SECURITY.md
Fixes two problems: - Auto watch doesn't re-run tests on file changes - Closing tests window doesn't close the test process in the command line
|
|
neryaco
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.17.2