Skip to content

Conversation

@orshemesh16
Copy link
Contributor

No description provided.

MerlinBot and others added 15 commits August 31, 2022 14:31
… your Repository

As a repository owner, you must take action to protect Microsoft against potential Software Supply Chain attacks. This starts with ensuring your repository has a valid Azure Artifacts usage so you can take advantage of [Central Feed Services](https://aka.ms/cfs). We are opening this PR with a fix on known issue(s) which we have detected in your repository. Please review and approve this PR at your earliest convenience.

**This may impact the ability for pipelines and developers to install packages and build projects.**

## Address **breaking changes** before you merge:
* Confirm the suggested Feed is configured per your organization's guidelines. If changes are necessary, work with your Project Administrators to set it up correctly.  [Learn more...](https://docs.microsoft.com/en-us/azure/devops/artifacts/feeds/feed-permissions?view=azure-devops)
* Add authentication to any failing pipeline definitions. [nuget](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/nuget-authenticate?view=azure-devops), [npm](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/npm-authenticate?view=azure-devops).
* Reach out to developers who may need to authenticate to the feed using the [embedded_PublicPackages's Connect to feed](https://dev.azure.com/powerbi/embedded/_artifacts/feed/embedded_PublicPackages/connect) instructions in Azure Artifacts.

## This PR can make changes to .npmrc, nuget.config, and other configuration files. Please view the complete change breakdown in the PR changed files.

---

For feedback or questions about this PR, please contact [Artifact Protection Services](mailto:[email protected]).

---

This change was automatically generated by [1ES Gardener](https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/gardener/1es-gardener) (a [MerlinBot](https://aka.ms/MerlinBot) extension) which is an initiative by the 1ES team to help repos stay up-to-date with latest tools, features, and best practices.
Add QuickCreate.ts to handle quickcreate validations
Add quickCreate in service to handle new quickCreate path
Refactored embed and move create() into each component
…1.12.1

bump version to 2.22.0, swith to use model version 1.12.1

Related work items: #776456
…urces config instead of npm authenticate task

Previously I added npm authenticate task to the pipeline to inject credentials to the .npmrc.
This task is not compliant to CDPX. I'm switching to YAML instead as mentioned in this [doc](https://onebranch.visualstudio.com/OneBranch/_wiki/wikis/OneBranch.wiki/4787/Consuming-Packages-in-a-CDPx-Pipeline?anchor=npm)
…upgrade

Export IQuickCreateConfiguration
Upgrade model version to 1.12.3

Related work items: #930573
bump version to 2.22.1
Includes minor bug fix and model version update

Related work items: #930573
…rbi-javascript-Buddy

Generate OneBranch Pipeline YAML config files. This pull request is initially auto-generated by Easy Start, for more details, please visit our [wiki](https://aka.ms/easystart).

**Difference Compared to powerbi-models repo PR:**

1. In the PR of powerbi-models, we ran power script files in CmdLine@2 using onebranch_run_ps.cmd file. But after May comment, in all the following PR we are using PowerShell@2 task to run our power script files and deleted onebranch_run_ps.cmd file.
2. In powerbi-javascript we also have a task to copy source artifacts to Output folder. Took a reference of this task from CDPx pipelines
3. We also have nuget_pack, so Added nugetInstaller task and to run nuget_pack.ps file and copy nugetpack to output folder

**Result of OneBranch Buddy Pipeline**
https://dev.azure.com/powerbi/Embedded/_build/results?buildId=5886126&view=results

**Drop Folder from OneBranch**
![image (3).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/1dd63332-e003-46a3-ac6f-70213a1bcc2e/pullRequests/309731/attachments/image%20%283%29.png)

**Drop Folder from CDPx**
![image (2).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/1dd63332-e003-46a3-ac6f-70213a1bcc2e/pullRequests/309731/attachments/image%20%282%29.png)
…rbi-javascript-Official

Generate OneBranch Pipeline YAML config files. This pull request is initially auto-generated by Easy Start, for more details, please visit our [wiki](https://aka.ms/easystart).

**Result of OneBranch Official Pipeline**
https://dev.azure.com/powerbi/Embedded/_build/results?buildId=6042686&view=results

Related work items: #972391
Add support of registering external components to SDK

How does it work?
1. User creates a new embed component extending `Embed` in his project
2. User implements the necessary code in FE to support hosting of the new component and handling events
3. Needed code to embed the new component:
`powerbi.register(componentType, embedComponentFactory, routerEventUrls);`
`powerbi.embed(embedContainer, config);`

powerbi.register:
- `componentType`: string representing the component type in embed configuration interface
- `embedComponentFactory`: function that returns a new instance of the embed component.
- `routerEventUrls`: list of urls to register, must use uniqueId and eventName as keys. something like that: `/componentName/:uniqueId/events/:eventName`

Example of calling powerbi.register for metric-picker  component:

```
    this.register(
      'metric_picker',
      (service, element, config, phasedRender, isBootstrap) => new MetricPicker(service, element, config, phasedRender, isBootstrap),
      ['/metricPicker/:uniqueId/events/:eventName']
    );
```
1. Updated vulnerable packages

2. Update webpack config devtool value to false which is equivalent to none of the lower versions

Related work items: #978292, #982650, #986527, #988932
Add report on blur event - lose focus

Two new methods added:

- clearVisualsSelection() -- Clears selected not popped out visuals, if flag is passed, all visuals selections will be cleared.
- closeAllOverlays() -- Closes all open PBI overlays (context menus, tooltips...)
@orshemesh16 orshemesh16 requested a review from ayeshurun January 31, 2023 11:09
@orshemesh16 orshemesh16 merged commit c4578b6 into master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants