Skip to content

CMake build: Add /CETCOMPAT for x64, /guard:MEOW for various architectures #5652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2025
Merged

CMake build: Add /CETCOMPAT for x64, /guard:MEOW for various architectures #5652

merged 5 commits into from
Sep 10, 2025

Conversation

matbech
Copy link
Contributor

@matbech matbech commented Jul 23, 2025 •
edited by StephanTLavavej
Loading

Fixes #5646. Fixes #5651.

@matbech matbech requested a review from a team as a code owner July 23, 2025 15:37
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jul 23, 2025
@StephanTLavavej StephanTLavavej added bug Something isn't working build Related to the build system labels Jul 23, 2025
StephanTLavavej
StephanTLavavej reviewed Jul 23, 2025
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Jul 23, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Work In Progress in STL Code Reviews Jul 23, 2025
@StephanTLavavej StephanTLavavej changed the title cmake build: Adds /CETCOMPAT for x86/x64 cmake build: Adds /CETCOMPAT for x64 Sep 2, 2025
StephanTLavavej
StephanTLavavej reviewed Sep 4, 2025
View reviewed changes
@StephanTLavavej StephanTLavavej changed the title cmake build: Adds /CETCOMPAT for x64 CMake build: Add /CETCOMPAT for x64, /guard:MEOW for various architectures Sep 4, 2025
@StephanTLavavej
Copy link
Member

My apologies for how long it took to get around to this. I audited the MSBuild machinery and extracted what I believe are the most important missing options. I verified both the GitHub and MSVC-internal builds, checking that the expected options are present or not for all architectures.

There are probably a few more missing flags but I believe this is a strict improvement.

@StephanTLavavej StephanTLavavej moved this from Work In Progress to Ready To Merge in STL Code Reviews Sep 4, 2025
@StephanTLavavej StephanTLavavej removed their assignment Sep 4, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Sep 10, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed

@StephanTLavavej StephanTLavavej merged commit 10b879e into microsoft:main Sep 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Sep 10, 2025
@StephanTLavavej
Copy link
Member

Thanks for noticing and fixing this very subtle build divergence! 🦅 👁️ 😻

@matbech matbech deleted the patch-1 branch September 10, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

No one assigned

Labels

bug Something isn't working build Related to the build system

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cmake build: missing /CETCOMPAT linker flag for x86/x64 cmake build: missing /guard:ehcont compiler flag

2 participants

@matbech @StephanTLavavej