<xstring>: Add more casts to basic_string for ASan
#5775
Merged
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Oct 10, 2025
|
/azp run STL-ASan-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5562.
I forgot that ASan activates conditionally compiled code, which also needs casts to avoid compiler warnings.
To simplify things, I'm also consistently extracting
_New_sizeso we don't need to repeat the cast expressions. I verified that this isn't introducing any shadowing.Thanks to @davidmrdavid and @zacklj89 for bringing this to my attention.