Skip to content

Simplify calculation of sourceFiles for getReferences #24475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
May 29, 2018
Merged

Simplify calculation of sourceFiles for getReferences #24475

1 commit merged into from
May 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2018

  • First case is just a filter.
  • In the second case, the slice() is unnecessary, since sourceFiles is used as a ReadonlyArray.

@ghost ghost requested a review from sheetalkamat May 29, 2018 22:59
@ghost ghost merged commit f411164 into master May 29, 2018
@ghost ghost deleted the references_sourceFiles branch May 29, 2018 23:12
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheetalkamat