For type emit, walk non-parent containers when those containers have aliases leading to the target #24507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aliases leading to the target
| @@ -66,9 +66,9 @@ export const x: import("./foo") = { x: 0, y: 0 }; | |||
| >0 : 0 | |||
|
|
|||
| export let y: import("./foo2").Bar.I = { a: "", b: 0 }; | |||
| >y : Bar.I | |||
| >y : import("tests/cases/conformance/types/import/foo2").Bar.I | |||
There was a problem hiding this comment.
Shouldn't this be import("./foo") instead of this whole path?
There was a problem hiding this comment.
Not in the types baselines - they have no enclosing declaration (or rather, they have no emit resolver with which to resolve the path to a local one because it's not really emit) specified for their type writer, so they get the whole path.
mhegazy
approved these changes
May 31, 2018
|
Please port to release-2.9 as well. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
May 31, 2018
…aliases leading to the target (microsoft#24507)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way aliases can expose paths to local types in
getAccessibleSymbolChain.Fixes this issue reported in this comment.