Do not watch parent folders recursively if not needed #24933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parents of root folder
This avoids watching folders like parent folder of the project root just to watch files created in the folder Fixes microsoft/vscode#51139
mhegazy
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#51139 further to avoid the unnecessary directory watch triggers
In case of AMD resolution, say we are trying to resolve module "fs" we would go looking for file fs.ts/fs.tsx/etc in each of the ancestor folder. At this point we use to create directory watch in the ancestor folder but to watch it recursively. This lead to the watch being triggered frequently. This fixes that issue since ancestor folders will be watched only for something directly in it. (eg. ancestor/fs.ts) In rest of the scenarios we will watch subdirectory of ancestor folder as shown in #24471