Handle the json extension when ResolvedModule result is json file #24959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Jun 14, 2018
|
Great work! |
timocov
reviewed
Jun 14, 2018
| } | ||
|
|
||
| const baseName = ts.getBaseFileName(fileName); | ||
| if (baseName === "package.json" || baseName === "tsconfig.json" || baseName === "jsconfig.json") { |
There was a problem hiding this comment.
baseName === "tsconfig.json"
But if we have tsconfig with a custom name, will it work?
There was a problem hiding this comment.
@sheetalkamat can you please take a look?
There was a problem hiding this comment.
I think you probably want to raise a new issue for this; I doubt people are looking at this as the original issue was solved and shipped with 3.0.0 AFAIK
|
Do you know when this is likely to be released? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24932