In JS, fix crash with in a file with conflicting ES2015/commonjs exports #24960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 14, 2018
src/compiler/binder.ts
Outdated
| @@ -2345,7 +2349,9 @@ namespace ts { | |||
| } | |||
|
|
|||
| // 'module.exports = expr' assignment | |||
| setCommonJsModuleIndicator(node); | |||
| if (!setCommonJsModuleIndicator(node)) { | |||
There was a problem hiding this comment.
Nit: The code was this way before, but this is a case of:
if (something) {
foo();
return;
}
foo();
doSomethingElse();The if (!setCommonJsModuleIndicator(node)) { return; } could be moved up before if (isEmptyObjectLiteral(assignedExpression) ... to avoid this duplication.
ghost
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the binder would try to bind commonjs
module.exportseven if the file was known to be an ES2015 module. This caused a crash in the checker when it tried to check the export symbol as a value.Fixes #24934