fix(46563): keyof autocomplete seems like it's missing autocomplete values with polymorphic this type #46581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Nov 19, 2021
There was a problem hiding this comment.
I don't think this is a problem with getTypeOfParameter, because you can get an assignability error if you pass the wrong thing with this, eg
this.baz(this, "")
this.baz(this, "completely wrong")That indicates to me that it's working. It seems more likely that this needs to be instantiated/converted to its constraint at the interface between the compiler and services, or maybe in completions.
a-tarasyuk
force-pushed
the
fix/46563
branch
from
d8a4308 to
dd6cd61
Compare
sandersn
approved these changes
Dec 3, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46563