Fix double-emit in constructor #53547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
approved these changes
Mar 27, 2023
weswigham
approved these changes
Mar 27, 2023
DanielRosenwasser
requested changes
Mar 27, 2023
DanielRosenwasser
approved these changes
Mar 27, 2023
|
@typescript-bot cherry-pick this to release-5.0 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #53550 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 27, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 28, 2023
…53550) Co-authored-by: Ron Buckton <[email protected]>
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…se-5.0 (microsoft#53550) Co-authored-by: Ron Buckton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the emit change in #53268 to avoid duplicate emit when
super()is not found.Fixes #53448