Skip to content

[Bugfix] Fix for Issue #6241 - ChromaDB removed IncludeEnum #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

[Bugfix] Fix for Issue #6241 - ChromaDB removed IncludeEnum #6260

merged 3 commits into from
Apr 10, 2025

Conversation

mpegram3rd
Copy link
Contributor

@mpegram3rd mpegram3rd commented Apr 10, 2025 •
edited
Loading

Why are these changes needed?

IncludeEnum was removed in ChromaDB when it was updated to 1.0.0. This caused issues when using ChromaDBVectorMemory. This PR fixes those issues

Related issue number

Closes #6241

Checks

@mpegram3rd
Copy link
Contributor Author

@mpegram3rd please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@mpegram3rd mpegram3rd mentioned this pull request Apr 10, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (1226a4f) to head (81ea4a6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6260      +/-   ##
==========================================
- Coverage   77.27%   77.27%   -0.01%     
==========================================
  Files         200      200              
  Lines       14322    14321       -1     
==========================================
- Hits        11068    11067       -1     
  Misses       3254     3254
Flag Coverage Δ
unittests 77.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpegram3rd
Copy link
Contributor Author

mpegram3rd commented Apr 10, 2025 •
edited
Loading

@victordibia the build last night uncovered one issue which I resolved. Would you mind approving this workflow so it can run again, and it should pass and be ready for full PR approval.

Thank you!

@victordibia victordibia self-requested a review April 10, 2025 16:40
@victordibia victordibia merged commit 196be34 into microsoft:main Apr 10, 2025
58 checks passed
@victordibia
Copy link
Collaborator

@mpegram3rd

@mpegram3rd mpegram3rd deleted the bugfix/chroma-memory-enum branch April 10, 2025 18:50
peterj added a commit to kagent-dev/autogen that referenced this pull request Apr 11, 2025
@peterj
Merge remote-tracking branch 'upstream/main' into fork-test
5cf0851 
* upstream/main: (120 commits)
  Update discover.md with adding email agent package (microsoft#6274)
  Expose TCM TypedDict classes for apps to use (microsoft#6269)
  Fix publish_message-method() notes (microsoft#6250)
  Fix ValueError: Dataclass has a union type error (microsoft#6266)
  [Bugfix] Fix for Issue microsoft#6241 - ChromaDB removed IncludeEnum (microsoft#6260)
  Add note on ModelInfo for Gemini Models (microsoft#6259)
  .NET update autogen 0.2.2 -> autogen 0.2.3 (microsoft#6257)
  [Draft] Enable File Upload/Paste as Task in AGS (microsoft#6091)
  Bugfix/azure ai search embedding (microsoft#6248)
  Expose more Task-Centric Memory parameters (microsoft#6246)
  fix: typo in usage.md (microsoft#6245)
  .NET update oai and aoai package version (microsoft#6239)
  Fix sha256_hash docstring (microsoft#6236)
  Update json_schema_to_pydantic version and make relaxed requirement on arry item. (microsoft#6209)
  Fix terminations conditions. (microsoft#6229)
  Docker Code Exec delete temp files (microsoft#6211)
  clean codes notes for autogen-core. (microsoft#6218)
  Fix/transformer aware any modelfamily (microsoft#6213)
  chore: Add powershell path check for code executor (microsoft#6212)
  added: gemini 2.5 pro preview (microsoft#6226)
  ...

Signed-off-by: Peter Jausovec <[email protected]>
abhinav-aegis pushed a commit to abhinav-aegis/autogen that referenced this pull request Apr 12, 2025
@mpegram3rd @victordibia @abhinav-aegis
[Bugfix] Fix for Issue microsoft#6241 - ChromaDB removed IncludeEnum (m…
99e296b 
…icrosoft#6260)

<!-- Thank you for your contribution! Please review
https://microsoft.github.io/autogen/docs/Contribute before opening a
pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

`IncludeEnum` was removed in ChromaDB when it was updated to `1.0.0`.
This caused issues when using `ChromaDBVectorMemory`. This PR fixes
those issues

## Related issue number

Closes microsoft#6241

## Checks

- [x] I've included any doc changes needed for
<https://microsoft.github.io/autogen/>. See
<https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to
build and test documentation locally.
- [x] I've added tests (if relevant) corresponding to the changes
introduced in this PR.
- [x] I've made sure all auto checks have passed.

---------

Co-authored-by: Victor Dibia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victordibia victordibia victordibia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'IncludeEnum' from 'chromadb.api.types'
2 participants
@mpegram3rd @victordibia