-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[Bugfix] Fix for Issue #6241 - ChromaDB removed IncludeEnum #6260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix for Issue #6241 - ChromaDB removed IncludeEnum #6260
Conversation
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6260 +/- ##
==========================================
- Coverage 77.27% 77.27% -0.01%
==========================================
Files 200 200
Lines 14322 14321 -1
==========================================
- Hits 11068 11067 -1
Misses 3254 3254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…bably due to updated ChromaDB lib
@victordibia the build last night uncovered one issue which I resolved. Would you mind approving this workflow so it can run again, and it should pass and be ready for full PR approval. Thank you! |
* upstream/main: (120 commits) Update discover.md with adding email agent package (microsoft#6274) Expose TCM TypedDict classes for apps to use (microsoft#6269) Fix publish_message-method() notes (microsoft#6250) Fix ValueError: Dataclass has a union type error (microsoft#6266) [Bugfix] Fix for Issue microsoft#6241 - ChromaDB removed IncludeEnum (microsoft#6260) Add note on ModelInfo for Gemini Models (microsoft#6259) .NET update autogen 0.2.2 -> autogen 0.2.3 (microsoft#6257) [Draft] Enable File Upload/Paste as Task in AGS (microsoft#6091) Bugfix/azure ai search embedding (microsoft#6248) Expose more Task-Centric Memory parameters (microsoft#6246) fix: typo in usage.md (microsoft#6245) .NET update oai and aoai package version (microsoft#6239) Fix sha256_hash docstring (microsoft#6236) Update json_schema_to_pydantic version and make relaxed requirement on arry item. (microsoft#6209) Fix terminations conditions. (microsoft#6229) Docker Code Exec delete temp files (microsoft#6211) clean codes notes for autogen-core. (microsoft#6218) Fix/transformer aware any modelfamily (microsoft#6213) chore: Add powershell path check for code executor (microsoft#6212) added: gemini 2.5 pro preview (microsoft#6226) ... Signed-off-by: Peter Jausovec <[email protected]>
…icrosoft#6260) <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? `IncludeEnum` was removed in ChromaDB when it was updated to `1.0.0`. This caused issues when using `ChromaDBVectorMemory`. This PR fixes those issues ## Related issue number Closes microsoft#6241 ## Checks - [x] I've included any doc changes needed for <https://microsoft.github.io/autogen/>. See <https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to build and test documentation locally. - [x] I've added tests (if relevant) corresponding to the changes introduced in this PR. - [x] I've made sure all auto checks have passed. --------- Co-authored-by: Victor Dibia <[email protected]>
Why are these changes needed?
IncludeEnum
was removed in ChromaDB when it was updated to1.0.0
. This caused issues when usingChromaDBVectorMemory
. This PR fixes those issuesRelated issue number
Closes #6241
Checks