Fixing issue with casing on operations wit_update_work_item rejects…
#326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lowercase operation values ("add", "replace", "remove"): returns error `invalid_enum_value`
Fixes #323
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
aaudzei
reviewed
Jul 22, 2025
aaudzei
approved these changes
Jul 23, 2025
|
|
||
| const result = await handler(params); | ||
|
|
||
| // This verifies that the updates are grouped by work item ID as implemented in line 643 |
There was a problem hiding this comment.
nitpick: i think we should remove line references from all comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of work item update operations in
src/tools/workitems.tsand enhances the corresponding test coverage intest/src/tools/workitems.test.ts. Key changes include simplifying the transformation of operation strings, removing redundant code, and adding tests for edge cases like API failures, operation transformations, and Markdown formatting.Refactoring and simplification:
operationToApiStringutility function and replaced it with an inline transformation usingzodschemas to convert operation strings to lowercase and validate them against allowed values (add,replace,remove) (src/tools/workitems.ts, [1] [2].opvalues instead of calling the removed utility function (src/tools/workitems.ts, src/tools/workitems.tsL480-R475).Enhanced test coverage:
test/src/tools/workitems.test.ts, test/src/tools/workitems.test.tsR430-R456).Add,Replace) to lowercase and their correct usage in API calls (test/src/tools/workitems.test.ts, test/src/tools/workitems.test.tsL608-R653).test/src/tools/workitems.test.ts, test/src/tools/workitems.test.tsR975-R1060).multilineFieldsFormatentry in the API request body (test/src/tools/workitems.test.ts, test/src/tools/workitems.test.tsR975-R1060).Fixes #323
GitHub issue number #323
Associated Risks
No risks
✅ PR Checklist
🧪 How did you test it?
Updated auto tests. Verified the tools works manually and updated cases on operations to account for uppper, lower, and combo