Skip to content

Conversation

fbeltrao
Copy link
Contributor

@fbeltrao fbeltrao commented Aug 7, 2025

The function get_work_items_batch_by_ids transforms the field System.AssignedTo to contain a simple name <email>. With pull request #385 , users can choose returned fields. It would be great to transform all possible identity fields:

  • System.AssignedTo
  • System.CreatedBy
  • System.ChangedBy
  • System.AuthorizedAs
  • Microsoft.VSTS.Common.ActivatedBy
  • Microsoft.VSTS.Common.ResolvedBy
  • Microsoft.VSTS.Common.ClosedBy

The proposed implementation leverages a list of known identity fields. An alternative would be to detect if the field looks like an identity. The risk is that it might find false positives.

GitHub issue number

#409

Associated Risks

Replace by possible risks this pull request can bring you might have thought of

PR Checklist

  • I have read the contribution guidelines
  • I have read the code of conduct guidelines
  • Title of the pull request is clear and informative.
  • 👌 Code hygiene
  • 🔭 Telemetry added, updated, or N/A
  • 📄 Documentation added, updated, or N/A
  • 🛡️ Automated tests added, or N/A

🧪 How did you test it?

  • Added new unit test

@fbeltrao fbeltrao requested a review from a team as a code owner August 7, 2025 15:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@51acb5f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage        ?   91.55%           
=======================================
  Files           ?       13           
  Lines           ?      841           
  Branches        ?      143           
=======================================
  Hits            ?      770           
  Misses          ?       40           
  Partials        ?       31           
Flag Coverage Δ
unittests 91.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fbeltrao fbeltrao force-pushed the feature/handle-users-fields branch from bb9e5da to a64715e Compare August 7, 2025 15:32
@fbeltrao fbeltrao changed the title Ttransform all possible identity fields to formatted strings in wit_get_work_items_batch_by_ids Transform all possible identity fields to formatted strings in wit_get_work_items_batch_by_ids Aug 7, 2025
@danhellem
Copy link
Contributor

per https://github.com/microsoft/azure-devops-mcp/blob/main/CONTRIBUTING.md please wait for Issue to be reviewed and approved before creating a PR

@danhellem danhellem merged commit c7ac0ef into microsoft:main Aug 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transform all possible identity fields in wit_get_work_items_batch_by_ids tool

3 participants