Move builds to pipelines.ts and update tests #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Novaes
previously approved these changes
Sep 2, 2025
|
|
||
| constructor(domainsInput?: string | string[]) { | ||
| this.enabledDomains = new Set(); | ||
| const normalizedInput = DomainsManager.parseDomainsInput(domainsInput); |
There was a problem hiding this comment.
If we are not using normalized name anymore we can remove the method parseDomainsInput from class normalizedInput just please.
Co-authored-by: Marcelo Novaes <[email protected]>
Novaes
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved build and pipeline tools to pipelines.ts
updates tests
renamed tools with prefixes for better naming
removed releases.ts and tools per PM request
GitHub issue number
#477
Associated Risks
Larger change, but low risk
✅ PR Checklist
🧪 How did you test it?
Manually
Added domain to test that
updated tests and re-rean them all