-
Notifications
You must be signed in to change notification settings - Fork 231
Support character-limit in list_sub tool #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds character-limit support to the Azure MCP Server's subscription list tool, allowing users to control response size through a new --character-limit
parameter with a default limit of 10,000 characters. When the response exceeds the limit, subscriptions are automatically truncated with informative status messages.
Key changes:
- Added
--character-limit
parameter to control response size with automatic truncation - Enhanced response messages to include character count and truncation status
- Added comprehensive test coverage for various character limit scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
CHANGELOG.md |
Documents the new character-limit parameter feature |
SubscriptionListCommandTests.cs |
Adds extensive test coverage for character limit functionality |
OptionDefinitions.cs |
Defines the new CharacterLimit option with 10,000 character default |
SubscriptionListOptions.cs |
Adds CharacterLimit property to subscription list options |
SubscriptionListCommand.cs |
Implements character limit logic with response truncation |
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs
Show resolved
Hide resolved
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs
Show resolved
Hide resolved
…o limit_sub_list
…o limit_sub_list
- Added `azmcp extension cli generate` command for generating Azure Cli commands based on user intent. [[#203](https://github.com/microsoft/mcp/issues/203)] | ||
- Added `azmcp extension cli install` command for getting installation instructions for Azure CLI, Azure Developer CLI and Azure Functions Core Tools. [[#74](https://github.com/microsoft/mcp/issues/74)] | ||
- Added `IsServerCommandInvoked` telemetry field indicating that the MCP tool call resulted in a command invocation. [[#751](https://github.com/microsoft/mcp/pull/751)] | ||
- Added `--character-limit` parameter to `azmcp_subscription_list` command to control response size. This parameter allows users to limit the number of characters returned in the response, with automatic truncation and informative status messages when the limit is exceeded. Default limit is 10,000 characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to issue or PR?
What does this PR do?
[Provide a clear, concise description of the changes]
Added character-limit switch in list_sub tool. If the response exceeds the limit, subscriptions are truncated.
#428
[Any additional context, screenshots, or information that helps reviewers]
GitHub issue number?
[Link to the GitHub issue this PR addresses]
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.md
and/orservers/Fabric.Mcp.Server/CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
)servers/Azure.Mcp.Server/README.md
and/orservers/Fabric.Mcp.Server/README.md
documentation/docs/azmcp-commands.md
and/or/docs/fabric-commands.md
ToolDescriptionEvaluator
and obtained a score of0.4
or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.md
crypto mining, spam, data exfiltration, etc.
)/azp run mcp - pullrequest - live
to run Live Test Pipeline