chore(mcp): handle cross-fs video moves #37663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows CI bots the video tests fail due to throwing an
EXDEV
error onrename
. This is because you can't rename across filesystems and Node doesn't automatically handle the underlying copy and remove that is necessary to replicate this functionality between disks.While this is failing specifically in our Windows CI at the moment, it could be affecting users across all platforms right now, though it is quite unlikely that their temp directory is on a different disk than the MCP server. Catch this particular error and retry with valid cross-fs operations, ultimately erroring out in the same way if necessary.