-
Notifications
You must be signed in to change notification settings - Fork 88
[MovieGen] update code to support MindSpore 2.7.0 #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hadipash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the MovieGen project's compatibility with newer MindSpore versions (2.6 and 2.7). It includes necessary code adjustments in the dataset loading pipeline to handle both image and video inputs more robustly, updates the project's performance benchmarks in the documentation to reflect the new MindSpore environment, and introduces a new shell script to simplify the execution of these benchmarks across various model configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the code to support MindSpore 2.7.0, including updating documentation, performance benchmarks, and refactoring the dataset loading logic. I've found a few critical issues in the dataset handling, particularly with video and GIF frame sampling, which could lead to incorrect data being fed into your models. I've also included some suggestions to improve the new benchmark script's robustness and maintainability. Please review the comments for details.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.