Skip to content

Conversation

hadipash
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Adds # (feature)

  • Add support for MindSpore 2.6 and 2.7.
  • Updated benchmarks based on MS 2.7.
  • Add shell script to run all benchmarks at once.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

Summary of Changes

Hello @hadipash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the MovieGen project's compatibility with newer MindSpore versions (2.6 and 2.7). It includes necessary code adjustments in the dataset loading pipeline to handle both image and video inputs more robustly, updates the project's performance benchmarks in the documentation to reflect the new MindSpore environment, and introduces a new shell script to simplify the execution of these benchmarks across various model configurations.

Highlights

  • MindSpore Version Update: The project now officially supports MindSpore versions 2.6 and 2.7, with all related configurations and benchmarks updated accordingly.
  • Enhanced Dataset Handling: The tae_dataset.py has been improved to intelligently differentiate and process both image and video files within the dataset, ensuring correct loading and transformation based on file type.
  • New Benchmark Script: A comprehensive shell script (train_perf_bench.sh) has been added to automate the execution of all performance benchmarks for 1B, 5B, and 30B models across their respective training stages.
  • Performance Table Refresh: The README.md now features updated performance metrics and compile times, reflecting the results obtained with MindSpore 2.7.0.
  • VideoReader Integration Update: The VideoReader utility is now imported from mindone.data instead of decord, and its usage in tae_dataset.py has been adjusted to fetch_frames for improved video processing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the code to support MindSpore 2.7.0, including updating documentation, performance benchmarks, and refactoring the dataset loading logic. I've found a few critical issues in the dataset handling, particularly with video and GIF frame sampling, which could lead to incorrect data being fed into your models. I've also included some suggestions to improve the new benchmark script's robustness and maintainability. Please review the comments for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant