-
Notifications
You must be signed in to change notification settings - Fork 70
FIX: Do not use Circle's premium layer caching #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Do not use Circle's premium layer caching #151
Conversation
@oesteban - circle ci required updates, but I'm pretty sure it doesn't solve the problem that some notebooks fail with new nipype |
Well, the first step was fixing the CI 👍 |
Also, compared to old builds in master - it seems tests now go substantially slower. Could that be the cause? |
sure! here are also some older tests from circleci: https://github.com/djarecka/nipype_tutorial/compare/master...djarecka:effigies/test1.5?expand=1 |
@oesteban - well, the test_3 get stuck |
Okay, master is already broken - let's merge this one and at least we'll be able to compare. It also adds a nightly build, so we notice when things break earlier. Let's try to find the problem through some other PR. |
@oesteban - while you are at this, I was thinking that the way we handle Having Dockerfile might be nice for the users, but we can add instruction how to create one |
That could possibly be a memory issue. If we are hitting swap at points then it makes sense tests are, in general, suffering from a slow down. We should try to pin nipype to the latest release after the previous successful build 8 months ago and see when we introduced the problem. |
Sounds good, but for a different PR |
I'm not sure how this could be a memory issue. The workflow shouldn't rerun the nodes at first place. The you can try to run the notebooks I sent you |
Seems master is broken for that reason.