Skip to content

Fix issue with BananaPi m5 (sleep 1 before umount) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntoninHuaut
Copy link

@AntoninHuaut AntoninHuaut commented Jan 3, 2023

#9

@mmgen
Copy link
Owner

mmgen commented Jan 3, 2023

Thanks for the patch. Does it make things work consistently?

Some of these added sleep statements are probably unnecessary, plus there might be a more reliable way to solve this, using sync, for example.

I'd like to better understand why this strange race condition exists in the first place.

@AntoninHuaut
Copy link
Author

Thanks for the patch. Does it make things work consistently?

I can't guarantee it but I reset my eMMC and the script ran perfectly on the first attempt and the eMMC was functional.

Some of these added sleep statements are probably unnecessary, plus there might be a more reliable way to solve this, using sync, for example.

Possibly, I needed for a project to encrypt my BananaPi but I have limited knowledge about disk management and storage.

I'd like to better understand why this strange race condition exists in the first place.

I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants