Skip to content

Deps: upgrade 'minimatch' #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2022
Merged

Deps: upgrade 'minimatch' #4865

merged 2 commits into from
Apr 8, 2022

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Apr 6, 2022 •
edited
Loading

Description

This is a breaking change and applies to the usage of --ignore (alias: --exclude) option in Windows.

see Minimatch docs

Please only use forward-slashes in glob expressions.
Though windows uses either / or \ as its path separator, only / characters are used by this glob implementation. You must use forward-slashes only in glob expressions. Back-slashes in patterns will always be interpreted as escape characters, not path separators.
Note that \ or / will be interpreted as path separators in paths on Windows, and will match against / in glob expressions.
So just always use / in patterns.

Description of the Change

dependencies from to
minimatch 4.2.1 5.0.1 breaking change

@juergba juergba self-assigned this Apr 6, 2022
@juergba juergba added area: windows Windows-specific semver-major implementation requires increase of "major" version number; "breaking changes" dependencies Pull requests that update a dependency file labels Apr 6, 2022
@juergba juergba added this to the v10.0.0 milestone Apr 6, 2022
@juergba juergba merged commit 3946453 into master Apr 8, 2022
@juergba juergba deleted the juergba/minimatch branch April 8, 2022 15:08
@aljones15 aljones15 mentioned this pull request Aug 4, 2022
Closed
@mfranzke mfranzke mentioned this pull request Mar 12, 2023
Draft
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@juergba juergba

Labels

area: windows Windows-specific dependencies Pull requests that update a dependency file semver-major implementation requires increase of "major" version number; "breaking changes"

Projects

None yet

Milestone

v10.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@juergba