-
Notifications
You must be signed in to change notification settings - Fork 545
Decouple Handlers and Collections from protocol types #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozkee
commented
Sep 11, 2025
78218a4
to
82b62cf
Compare
src/ModelContextProtocol.Core/Protocol/ElicitationCapability.cs
Outdated
Show resolved
Hide resolved
…ion) from Capabilities by promoting them to the options types. Also, group all handlers in container classes, for server, I decided to move McpServerHandlers down to Mcp.Core and move the NotificationHandlers there too. Also, Fix ListResourceTemplatesHandler issue.
180dcd0
to
0a0ff59
Compare
src/ModelContextProtocol.Core/Protocol/CompletionsCapability.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2025
src/ModelContextProtocol.Core/Protocol/CompletionsCapability.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple Handlers and Collections (e.g. ToolsHandler and ToolsCollection) from Capabilities by promoting them to the options types.
Also, group all handlers in container classes, for server, I decided to move McpServerHandlers down to Mcp.Core and move the NotificationHandlers there too.
Breaking Changes (Migration Summary)
Handlers and collections in the Capabilities types are now obsolete; they've been moved to
McpClientOptions
andMcpServerOptions
.1. Collections
Replace usages of the obsolete collections with the corresponding collections on the options types:
Old
New
2. Handlers
Replace usages of the obsolete handlers with the corresponding handlers on the options types:
Old
New
Mapping (Old → New)