Skip to content

feat: client-extensions #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EItanya
Copy link
Contributor

@EItanya EItanya commented Apr 11, 2025

Add extensions to the client macros

Motivation and Context

I am developing a client and I need to be able to pass extensions through my requests.

How Has This Been Tested?

Breaking Changes

This breaks the current macro code. I tried thinking of a way to do it without breaking, but I couldn't come up with any good ideas. Maybe a request builder where we can call with_extensions. Open to ideas here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@salman1993
Copy link

salman1993 commented Apr 12, 2025

what are extensions supposed to be in this case? i couldn't find any reference to extensions in MCP spec.

@4t145
Copy link
Collaborator

4t145 commented Apr 26, 2025

Sorry for late response. My opinion is to keep the basic api simple. If extension is a parameter here, why not other options like timeout or other things else. Maybe we could add extensions by calling send_request, or we could add a helper method to help to specific response type. Maybe we can have a trait to convert different request into json rpc resquest and give it response type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants