Update registerTool
function signature for proper typed ToolCalback
#1035
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerTool
signature to provide the accurate type for theToolCallback
Motivation and Context
inputSchma
is provided, given the generic, it will assume theToolCallback
function will always becb(params, extra)
even though it should becb(extra)
params
will be typed as theRecord<string, any>
even though it should be typedRequestHandlerExtra
andextra
would be typed asRequestHandlerExtra
but actually beundefined
ToolCallback
where ifinputSchema
isundefined
, the callback will becb(extra)
and ifinputSchema
is defined, it will becb(params, extra)
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist