Skip to content

Conversation

@arjunkmrm
Copy link
Contributor

@arjunkmrm arjunkmrm commented Aug 7, 2025

Fixed missing fetchFn parameter in registerClient and refreshAuthorization function calls in the auth flow

Motivation and Context

The authInternal function accepts a fetchFn parameter and correctly passes it to most HTTP calls (discoverOAuthProtectedResourceMetadata, discoverAuthorizationServerMetadata, exchangeAuthorization), but was missing it in calls to registerClient and refreshAuthorization. This caused these functions to fall back to the global fetch instead of using any custom fetchFn provided, creating inconsistent behavior in scenarios requiring custom network configurations, testing with mock fetch functions, or environments where global fetch might not be available.

How Has This Been Tested?

Tested in our application at Smithery (https://smithery.ai)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@arjunkmrm arjunkmrm requested review from a team and ochafik August 7, 2025 02:39
@arjunkmrm arjunkmrm marked this pull request as draft August 7, 2025 02:51
@arjunkmrm arjunkmrm marked this pull request as ready for review August 7, 2025 03:46
Copy link
Member

@pcarleton pcarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pcarleton pcarleton merged commit aad33a1 into modelcontextprotocol:main Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants