fix(desktop): restore off-screen main window by xianjianlf2 · Pull Request #2203 · moeru-ai/airi

xianjianlf2 · 2026-08-03T08:44:35Z

Summary

Validate persisted main-window bounds against the current display work area before creating the Electron window.
Keep move/resize persistence reachable and fall back to the primary display when the saved display is unavailable.
Add focused coverage for fully off-screen, partially off-screen, and unavailable-display recovery.

Validation

corepack pnpm --filter @proj-airi/stage-tamagotchi exec vitest run
corepack pnpm --filter @proj-airi/stage-tamagotchi exec eslint src/main/windows/main/index.ts src/main/windows/shared/display.ts src/main/windows/shared/display.test.ts
corepack pnpm --filter @proj-airi/stage-tamagotchi run typecheck
corepack pnpm --filter @proj-airi/stage-tamagotchi run build

Fixes #2181

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60a1d14e60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xianjianlf2 · 2026-08-05T13:11:50Z

已推送 3f94c941 同步最新 main；当前 head 包含窗口边界恢复修复及对应测试。@nekomeowww 请复审。

xianjianlf2 · 2026-08-06T11:32:58Z

The requested window recovery change is implemented in 3f94c94:

persisted bounds are recovered on startup;
intermediate move events are not clamped, so the window can cross displays;
recovery is debounced after moving completes;
tests cover fully off-screen, partially off-screen, and unavailable-display fallback cases.

Could you please re-review this update?

xianjianlf2 · 2026-08-06T11:35:19Z

Rebased onto the latest main and pushed as 27bfa3f. The window recovery fix still passes the targeted display tests (23/23) and lint checks. The implementation restores persisted off-screen bounds at startup, avoids clamping intermediate moves, and debounces recovery after moving completes. Please re-review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27bfa3f54e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: MarkXian <mark-xian@foxmail.com>

xianjianlf2 · 2026-08-07T03:37:55Z

已修复 P2 review 并推送 2050465：只有保存的窗口 bounds 与当前显示器 bounds 有实际交集时才使用 getDisplayMatching；完全属于已断开显示器的 bounds 会回退到主显示器。新增 rectanglesOverlap 测试。验证：stage-tamagotchi 全量 366 passed、1 skipped，ESLint 通过。typecheck/build 仍受基线已有的 eventa/better-fetch 类型冲突和 audio 缺少 toWavFromPCM16 导出阻塞。请重新 review。

xianjianlf2 · 2026-08-07T03:37:56Z

@codex review

chatgpt-codex-connector · 2026-08-07T03:38:03Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2050465044

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xianjianlf2 · 2026-08-07T04:23:47Z

补充处理了最新 review：resize-only 拖动只触发 Electron 的 resize 事件，之前只在 move 后恢复边界，可能让窗口继续越过工作区。现在 resize 与 move 共用 250ms trailing debounce，窗口调整结束后都会执行边界恢复。

提交：ca097a240

验证：display tests 25/25、stage-tamagotchi lint 通过；typecheck 仍被基线的 @moeru/eventa 重复版本、缺失 toWavFromPCM16 和 @better-fetch/fetch 阻塞。

xianjianlf2 · 2026-08-07T04:23:49Z

@codex review

chatgpt-codex-connector · 2026-08-07T04:24:00Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

…ow-bounds-2181

xianjianlf2 · 2026-08-11T06:53:17Z

Rebased/synced this branch onto the latest main and pushed 3e3d6df. There were no merge conflicts.\n\nCurrent local validation after the sync:\n- pnpm install --frozen-lockfile\n- pnpm -F @proj-airi/stage-tamagotchi exec vitest run src/main/windows/shared/display.test.ts (25 passed)\n- pnpm -F @proj-airi/stage-tamagotchi run lint\n- pnpm -F @proj-airi/stage-tamagotchi exec vitest run (357 passed, 1 skipped)\n- pnpm -F @proj-airi/stage-tamagotchi run typecheck\n\nThe latest resize/move recovery changes are preserved after the main sync. Please re-review when convenient.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e3d6df2e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ow-bounds-2181

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea63c22203

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ow-bounds-2181

xianjianlf2 · 2026-08-13T04:01:18Z

Synced this branch with the latest main and pushed merge commit 9fef14c. There were no merge conflicts; the PR diff remains scoped to the main-window bounds recovery files.\n\nLocal validation after the sync:\n- pnpm -F @proj-airi/stage-tamagotchi exec vitest run src/main/windows/shared/display.test.ts (25 passed)\n- pnpm -F @proj-airi/stage-tamagotchi run lint\n- git diff --check origin/main...HEAD

xianjianlf2 · 2026-08-13T06:19:07Z

Addressed the latest regression-test traceability feedback in cc011152:

Added the Issue Desktop: dragging the main window off-screen persists an unrecoverable position #2181 URL to the ROOT CAUSE block.
Updated the first recovery regression test name to explicitly reference Issue Desktop: dragging the main window off-screen persists an unrecoverable position #2181.

Validation:

corepack pnpm --filter @proj-airi/stage-tamagotchi exec vitest run src/main/windows/shared/display.test.ts (25 passed)
corepack pnpm --filter @proj-airi/stage-tamagotchi exec eslint src/main/windows/shared/display.test.ts
git diff --check

Please re-review when convenient.

xianjianlf2 · 2026-08-13T07:09:48Z

All current review conversations are now resolved. The latest head is cc011152, with the window recovery regression traceability update and the previous display fallback/JSDoc fixes preserved. Please re-review when convenient.

…ndow-bounds-2181 # Conflicts: # apps/stage-tamagotchi/src/main/windows/main/index.ts # apps/stage-tamagotchi/src/main/windows/shared/display.ts

xianjianlf2 · 2026-08-29T06:22:49Z

Synced this branch with current upstream/main and resolved the conflict state in merge commit b3abab1ef3a25ce216934bdb79dd4002a5930dd1.

Conflict resolution:

apps/stage-tamagotchi/src/main/windows/main/index.ts: preserved upstream setWindowAlwaysOnTop / withHashRoute changes and kept this PR’s rectanglesOverlap / restoreWindowBounds recovery path.
apps/stage-tamagotchi/src/main/windows/shared/display.ts: kept this PR’s off-screen restore helpers, while using upstream’s shared DisplayArea / findDominantDisplayArea implementation instead of the removed local duplicate.

Local validation:

git diff --check

I attempted corepack pnpm install --frozen-lockfile to rerun the previous Vitest/ESLint checks, but the local install could not complete because repeated registry downloads timed out (operation was aborted due to timeout). CI is now running on the pushed merge commit and should provide the full validation signal.

chatgpt-codex-connector · 2026-08-29T06:22:51Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-29T08:14:48.337270Z	`abbec0a`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-08-29T06:22:51Z

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

…ndow-bounds-2181

xianjianlf2 · 2026-08-29T08:11:48Z

Updated the branch with the latest upstream/main to clear the BEHIND state.\n\nLocal validation:\n- pnpm run typecheck\n- pnpm exec vitest run apps/stage-tamagotchi/src/main/windows/shared/display.test.ts\n- pnpm run lint\n- git diff --check\n\nNote: two earlier parallel pnpm commands failed during dependency linking with ENOTEMPTY because they were started concurrently; rerunning the checks serially after install completed passed.

xianjianlf2 · 2026-08-31T02:19:56Z

All requested follow-ups are present on the current branch: recovery is scheduled after both move and resize events, the 250 ms workaround has the required NOTICE/source/removal condition, and the display regressions include the ROOT CAUSE block plus Issue #2181 name/link traceability. I resolved the addressed threads; could you please re-review when convenient?

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread apps/stage-tamagotchi/src/main/windows/main/index.ts Outdated

nekomeowww requested changes Aug 4, 2026

View reviewed changes

xianjianlf2 force-pushed the fix/restore-main-window-bounds-2181 branch from 3f94c94 to 27bfa3f Compare August 6, 2026 11:35

chatgpt-codex-connector Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread apps/stage-tamagotchi/src/main/windows/main/index.ts

xianjianlf2 added 3 commits August 7, 2026 11:35

fix(desktop): restore off-screen main window

02416de

Signed-off-by: MarkXian <mark-xian@foxmail.com>

fix(desktop): defer main window bounds recovery after move

ebbd352

fix(desktop): fallback when saved display is disconnected

2050465

xianjianlf2 force-pushed the fix/restore-main-window-bounds-2181 branch from 27bfa3f to 2050465 Compare August 7, 2026 03:37

chatgpt-codex-connector Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/stage-tamagotchi/src/main/windows/main/index.ts Outdated

fix(desktop): recover bounds after resize events

ca097a2

Merge remote-tracking branch 'origin/main' into fix/restore-main-wind…

3e3d6df

…ow-bounds-2181

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread apps/stage-tamagotchi/src/main/windows/main/index.ts Outdated

Comment thread apps/stage-tamagotchi/src/main/windows/shared/display.ts

Comment thread apps/stage-tamagotchi/src/main/windows/shared/display.test.ts Outdated

xianjianlf2 added 2 commits August 11, 2026 22:03

test(stage-tamagotchi): document window bounds recovery

c082bb7

Merge remote-tracking branch 'origin/main' into fix/restore-main-wind…

ea63c22

…ow-bounds-2181

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread apps/stage-tamagotchi/src/main/windows/shared/display.test.ts Outdated

Merge remote-tracking branch 'origin/main' into fix/restore-main-wind…

9fef14c

…ow-bounds-2181

test(stage-tamagotchi): link window recovery regression

cc01115

Merge remote-tracking branch 'upstream/main' into fix/restore-main-wi…

b3abab1

…ndow-bounds-2181 # Conflicts: # apps/stage-tamagotchi/src/main/windows/main/index.ts # apps/stage-tamagotchi/src/main/windows/shared/display.ts

Merge remote-tracking branch 'upstream/main' into fix/restore-main-wi…

abbec0a

…ndow-bounds-2181

Uh oh!

Uh oh!

Conversation

xianjianlf2 commented Aug 3, 2026

Summary

Validation

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xianjianlf2 commented Aug 5, 2026

Uh oh!

xianjianlf2 commented Aug 6, 2026

Uh oh!

xianjianlf2 commented Aug 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xianjianlf2 commented Aug 7, 2026

Uh oh!

xianjianlf2 commented Aug 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xianjianlf2 commented Aug 7, 2026

Uh oh!

xianjianlf2 commented Aug 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 7, 2026

Uh oh!

xianjianlf2 commented Aug 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xianjianlf2 commented Aug 13, 2026

Uh oh!

xianjianlf2 commented Aug 13, 2026

Uh oh!

xianjianlf2 commented Aug 13, 2026

Uh oh!

xianjianlf2 commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

github-actions Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Uh oh!

xianjianlf2 commented Aug 29, 2026

Uh oh!

xianjianlf2 commented Aug 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

chatgpt-codex-connector Bot commented Aug 29, 2026 •

edited

Loading

github-actions Bot commented Aug 29, 2026 •

edited

Loading