Migrate com.mongodb.client.unified.UnifiedTest and all its descendants to JUnit 5
#1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
force-pushed
the
JAVA-5495
branch
7 times, most recently
from
c76a97b to
dd860a3
Compare
…nts/users to JUnit 5 JAVA-5495
rozza
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Firstly - changes look good.
However, there appears to be a discrepency in the number of tests against master:
-
Master: 4.0 Replica Set NoAuth NoSSL JDK8 Linux 15698/15698 tests
-
Patch: 4.0 Replica Set NoAuth NoSSL JDK8 Linux: 15666/15666 tests
-
Master: latest Sharded Cluster Auth SSL JDK8 Linux 15725/15725 tests
-
Patch: latest Sharded Cluster Auth SSL JDK8 Linux 15693/15693 tests
I'm going to update with master just to double check them.
|
Thats all it was - merged in master and counts for those two are equal 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to move most ofUnifiedTest.setUptoUnifiedTest.shouldPassAllOutcomesbecause there is no out of the box way to inject test parameters inUnifiedTest.setUp, and JUnit Pioneer also does not have such an extension. This is, however, technically possible based on JUnit 5 docs, and https://stackoverflow.com/a/69265907 suggests a solution.AfterBeforeParameterResolver, so just reused.I also added some more new and potentially useful info to JAVA-5393: Retry non-buggy flaky tests.
JAVA-5495