Skip to content

CLOUDP-322512: Use latest SDK for atlas deployments list #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Jun 5, 2025

Proposed changes

Jira ticket: CLOUDP-322512

  • Atlas deployments list is an L3 command that does not support json output. Hence, we can use the latest SDK version to list Atlas clusters.

Test

➜  mongodb-atlas-cli git:(CLOUDP-322512) ✗ ./bin/atlas deployments list -P prod --debug
Using Docker enginefailed to retrieve local deployments with: could not determine docker version
exit status 1: Cannot connect to the Docker daemon at unix:///Users/bianca.vianadeaguiar/.docker/run/docker.sock. Is the docker daemon running?

2025/06/05 17:11:34
GET /api/atlas/v2/groups/628cd59b9730b52805a8105e/clusters?includeCount=false&includeDeletedWithRetainedBackups=false&itemsPerPage=500&pageNum=1 HTTP/1.1
Host: cloud.mongodb.com
User-Agent: atlascli/1.43.0-20-g9ce0562ce (darwin;arm64;native)
Accept: application/vnd.atlas.2024-08-05+json
Accept-Encoding: gzip


2025/06/05 17:11:34
HTTP/1.1 200 OK
Content-Type: application/vnd.atlas.2024-08-05+json;charset=utf-8
Date: Thu, 05 Jun 2025 16:11:34 GMT
Referrer-Policy: strict-origin-when-cross-origin
Server: mdbws
Strict-Transport-Security: max-age=31536000; includeSubdomains;
Vary: Accept-Encoding
X-Content-Type-Options: nosniff
X-Envoy-Upstream-Service-Time: 99
X-Frame-Options: DENY
X-Mongodb-Service-Version: gitHash=4294a70e77b8f6baa20168eaac71d81e3c0ae442; versionString=v20250604
X-Permitted-Cross-Domain-Policies: none

NAME       TYPE    MDB VER   STATE
Cluster0   ATLAS   8.0.9     IDLE

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the base branch from master to CLOUDP-302696-clusters-iss-epic June 5, 2025 15:10
@blva blva marked this pull request as ready for review June 5, 2025 15:10
@blva blva requested a review from a team as a code owner June 5, 2025 15:10
@github-actions github-actions bot removed the atlascli label Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Coverage Report 📈

Branch Commit Coverage
CLOUDP-302696-clusters-iss-epic 525940e 25.1%
CLOUDP-322512 d14f239 25.1%
Difference 0%

Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blva blva merged commit fe75b12 into CLOUDP-302696-clusters-iss-epic Jun 6, 2025
19 checks passed
@blva blva deleted the CLOUDP-322512 branch June 6, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants