Update prompt for UI blocks #7032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
reviewed
Nov 13, 2025
Contributor
escattone
left a comment
escattone
left a comment
There was a problem hiding this comment.
This seems like an improvement on the existing prior-translation-wiki-map, but I don't think it will affect the UI elements, which are covered by the menu, button, and pref tags. I think we'd have to include those tags in the prior-translation-wiki-map in order to improve the handling of the UI elements.
Collaborator
Author
|
No objections on this. Shall we do this iteratively and merge this improvement? |
escattone
approved these changes
Nov 15, 2025
kitsune/llm/l10n/prompt.py
Outdated
| - A Python `dict` maps keys to their values. | ||
| - Each `wiki-hook`, `wiki-article-link`, and `wiki-external-link` in the {{ source_language }} text of the "prior translation" becomes a key in the `prior-translation-wiki-map`, and each key's value is its corresponding translation found in the {{ target_language }} text of the "prior translation". | ||
| - **IMPORTANT**: Extract **ALL** `wiki-hook`, `wiki-article-link`, and `wiki-external-link` elements from the **ENTIRE** {{ source_language }} text of the "prior translation". Each element becomes a key in the `prior-translation-wiki-map`, and each key's value is its corresponding translation found in the {{ target_language }} text of the "prior translation". | ||
| - This map preserves human-localized wiki elements, which **must be reused** whenever those elements appear anywhere in your translation, regardless of whether they appear in changed or unchanged sections. |
Contributor
There was a problem hiding this comment.
I would use "This `prior-translation-wiki-map` ..." instead of "This map ..." just to be crystal clear.
kitsune/llm/l10n/prompt.py
Outdated
| 4. For each part that is different, **freshly translate** that part. **Remember to obey the `Rules for translating special strings`**. | ||
| 4. For each part that is different, **freshly translate** that part: | ||
| - **Remember to obey ALL of the `Rules for translating special strings`**. | ||
| - **CRITICAL**: Even in different/changed parts, you **MUST** check the `prior-translation-wiki-map` for every wiki element (per Rule #3) before translating. This ensures already-localized UI elements are preserved. |
Contributor
There was a problem hiding this comment.
I would use wiki elements instead of UI elements.
akatsoulas
force-pushed
the
update-l10n-prompt
branch
from
87ec0d6 to
e514df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.